Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

Conversation

@squeed
Copy link
Contributor

@squeed squeed commented Oct 12, 2016

Fixes #3144

@squeed squeed added this to the v1.17.0 milestone Oct 12, 2016
@jonboulle
Copy link
Contributor

can you mention something about checking the signatures? (would be nice if we could use the actual package manager trust databases too..)

@squeed
Copy link
Contributor Author

squeed commented Oct 12, 2016

Signing the packages using the proper mechanisms is a pain (mostly 'cause we build in a container), plus dpkg doesn't even validate embedded signatures by default.

@squeed
Copy link
Contributor Author

squeed commented Oct 12, 2016

OK, updated the commit to include manual verification. We can do embedded package signatures, someday.

Copy link
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, else LGTM

-d dbus \
-d libc6 \
-d systemd \
-d iptables \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one uses a tab for indentation, the other lines use spaces.

@s-urbaniak
Copy link
Contributor

closing in favor of #3281

@s-urbaniak s-urbaniak closed this Oct 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants