This repository was archived by the owner on Feb 24, 2020. It is now read-only.
api_service: Use image manifest in the pod directory for List/Inspect pod #1936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a9c6e59 to
e6e896a
Compare
e10e2de to
833c6ce
Compare
|
@jonboulle I think we should also consider:
|
|
Sorry, I don't understand either of your questions. can you elaborate/give an example? |
|
This commit changes the way how List/Inspect pod fetches image manifest for apps. Previously, the manifest is read from store, which will be empty if the image is removed. Now the manifest is read from the image manifest inside the pod directory, so it won't be affected by image removal. However, some information like importtime, image size are not available for List/Inspect pod after this change.
|
Gotcha.
Let's just add
No, I don't think so. |
This was referenced Jan 13, 2016
|
@jonboulle Created issues for the questions. Is this one ok to merge? |
|
LGTM |
yifan-gu
added a commit
that referenced
this pull request
Jan 13, 2016
api_service: Use image manifest in the pod directory for List/Inspect pod
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the way how List/Inspect pod fetches image manifest
for apps. Previously, the manifest is read from store, which will be empty
if the image is removed. Now the manifest is read from the image manifest
inside the pod directory, so it won't be affected by image removal.
However, some information like importtime, image size are not available
for List/Inspect pod after this change.
Should fix #1924 (comment)
cc @derekparker @jonboulle @krnowak