Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

stage0: print log messages only when debug is enabled #1557

Merged
merged 3 commits into from
Oct 12, 2015
Merged

stage0: print log messages only when debug is enabled #1557

merged 3 commits into from
Oct 12, 2015

Conversation

@iaguis
Copy link
Member

@iaguis iaguis commented Oct 7, 2015

Fixes #1504

@iaguis iaguis added this to the v0.10.0 milestone Oct 7, 2015
@jellonek
Copy link
Contributor

jellonek commented Oct 7, 2015

LGTM

@jonboulle
Copy link
Contributor

please rebase

iaguis added 2 commits October 8, 2015 23:49
@iaguis
stage0: print log messages only when debug is enabled
67344e0
@iaguis
functional tests: fix TestShortHash
37186dd 
We don't print "Writing pod manifest" if prepare is not called with
--debug anymore.
@alban
Copy link
Member

alban commented Oct 12, 2015

Some documentation needs to be updated:

$ git grep 'Preparing stage1'
Documentation/getting-started-ubuntu-vivid.md:2015/08/03 08:57:23 Preparing stage1
Documentation/running-lkvm-stage1.md:2015/08/18 16:10:03 Preparing stage1
Documentation/subcommands/prepare.md:2015/10/01 16:40:06 Preparing stage1

@alban
Copy link
Member

alban commented Oct 12, 2015

Can you also run the command from #1504 and paste the output here to see how it looks like?

@iaguis
Copy link
Member Author

iaguis commented Oct 12, 2015 

> sudo rkt run --mds-register=false --insecure-skip-verify=true docker://busybox --interactive
rkt: using image from file /home/iaguis/work/coreos/go/src/github.com/coreos/rkt/build-rkt/bin/stage1-coreos.aci
rkt: using image from local store for url docker://busybox
/ #

@iaguis
Copy link
Member Author

iaguis commented Oct 12, 2015

Thanks!

@alban
Copy link
Member

alban commented Oct 12, 2015

LGTM

iaguis added a commit that referenced this pull request Oct 12, 2015
@iaguis
Merge pull request #1557 from iaguis/stage0-debug
396e345 
stage0: print log messages only when debug is enabled
@iaguis iaguis merged commit 396e345 into rkt:master Oct 12, 2015
@jonboulle
Copy link
Contributor

out of interest why did you choose to mutate a global variable rather than, say, passing it as a flag to stage0.Prepare()/Run() ?

@iaguis
Copy link
Member Author

iaguis commented Oct 13, 2015

So we could use it somewhere else without passing the {Prepare,Run}Config although now I see that we use it only in functions that already have that parameter...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

area/usability component/stage0 kind/friction needs/review

Projects

None yet

Milestone

v0.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@iaguis @jellonek @jonboulle @alban