Update for compatibility with IPython 5.0 #65

caethan · 2016-07-12T17:22:01Z

Replaces the depreciated ip.define_magic() method with ip.register_magics() and some modifications to handle the different API required.

Also tested with IPython 4.1.1. I don't know how far back the ip.register_magics() method goes, so I'm not sure how far back it's compatible.

Edit: Apparently the new API was included as far back as 0.13, and the old API was finally removed in 5.0. So removing support for the old API entirely is pretty unlikely to cause problems.

Also tested with IPython 4.1.1. Replaces the depreciated ip.define_magic() method with ip.register_magics() and some modifications to handle the different API required.

The new magic decorators need ipython imported at a module level

wholmgren · 2016-07-12T18:12:20Z

Works for me on 5.0.0 -- thanks @caethan!

tguillemot · 2016-07-16T01:00:18Z

Seem's that travis is not happy.

tguillemot · 2016-07-16T02:39:36Z

dev_requirements.txt

@@ -1 +1,2 @@
-Cython
+ipython
+Cython --install-option='--no-cython-compile'


Travis don't like you pass the option like this. I don't know how to give it correctly.
I suggest that you let this file as it was before and add pip install ipython in .travis.yml.

tguillemot · 2016-07-16T02:46:00Z

@caethan Thanks for the solution. I've tell you how to change travis to pass the tests.

jingkungao · 2016-07-31T19:53:57Z

@caethan Thanks for the solution. This works perfectly for me!

caethan · 2016-08-12T17:03:48Z

Fixed the travis build. Thanks for the fixes, @tguillemot !

danielballan · 2016-08-15T15:01:45Z

Thanks @caethan. It would be great to see this merged and released on PyPI soon.

cancan101 · 2016-08-24T14:34:10Z

How does this compare to #68?

caethan · 2016-08-30T18:45:04Z

@cancan101: Looks like #68 is a better approach - no need to include IPython as a specific dependency there. I'd use that one (assuming it works, haven't tested it myself).

esafak · 2016-08-31T01:46:09Z

This does not work for me on IPython 5.1 & Jupyter NB 4.2.2:

/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/IPython/core/extensions.py in _call_load_ipython_extension(self, mod)
    130     def _call_load_ipython_extension(self, mod):
    131         if hasattr(mod, 'load_ipython_extension'):
--> 132             mod.load_ipython_extension(self.shell)
    133             return True
    134 

/Users/esafak/Library/Python/3.5/lib/python/site-packages/line_profiler.py in load_ipython_extension(ip)
    370 
    371         return return_value
--> 372 
    373 
    374 def load_ipython_extension(ip):

AttributeError: 'ZMQInteractiveShell' object has no attribute 'define_magic'

caethan · 2016-09-02T04:29:53Z

@esafak Sure looks like you're using the master branch without this bug fix.

tguillemot · 2016-09-02T07:37:40Z

@caethan I'm agree with you. #68 is a better solution indeed.

patricksnape · 2016-09-09T08:00:23Z

#68 is not a better fix - this is the fix. The way that magic functions are defined has changed and they are no longer passed a reference to self so functions like parse_options don't exist unless the magic function extends the Magics class. Therefore, this is the correct fix.

wesm · 2016-09-12T02:41:31Z

Throwing in my support for this fix. I ran into this failure when updating the IPython section of my book (where I use line_profiler)

caethan · 2016-09-15T18:25:50Z

@patricksnape: Thanks for checking #68!

alimuldal · 2016-09-18T00:31:41Z

Is there anything preventing this from being merged?

wesm · 2016-09-29T13:11:18Z

@rkern?

espg · 2016-10-15T04:44:46Z

does not work for me on iPython 5.1 either:

IPython 5.1.0 -- An enhanced Interactive Python.
...
[TerminalIPythonApp] WARNING | Error in loading extension: line_profiler_ext
Check your config files in /Users/grigsbye/.ipython/profile_default
Traceback (most recent call last):
File "/usr/local/lib/python3.5/site-packages/IPython/core/shellapp.py", line 246, in init_extensions
self.shell.extension_manager.load_extension(ext)
File "/usr/local/lib/python3.5/site-packages/IPython/core/extensions.py", line 85, in load_extension
if self._call_load_ipython_extension(mod):
File "/usr/local/lib/python3.5/site-packages/IPython/core/extensions.py", line 132, in _call_load_ipython_extension
mod.load_ipython_extension(self.shell)
File "/Users/grigsbye/.ipython/extensions/line_profiler_ext.py", line 4, in load_ipython_extension
ip.define_magic('lprun', line_profiler.magic_lprun)
AttributeError: 'TerminalInteractiveShell' object has no attribute 'define_magic'

danielballan · 2016-10-15T06:55:09Z

@espg Have you tried installing the branch from this PR? That error message suggests you have the current version of line_profiler installed, which won't work on 5.0 or greater.

jakirkham · 2016-10-17T20:07:39Z

What needs to be done to get this merged? Anything we can help with?

espg · 2016-10-17T20:25:58Z

@danielballan I ran:

~ ➤ pip3 install git+https://github.com/rkern/line_profiler.git

Collecting git+https://github.com/rkern/line_profiler.git
Cloning https://github.com/rkern/line_profiler.git to /tmp/pip-is2n9c7m-build
Installing collected packages: line-profiler
Running setup.py install for line-profiler ... done
Successfully installed line-profiler-1.0

to install the branch... running ipython gives the errors in my other post. Note that this is on iPython 5.1.0 and python 3.5.2

gforsyth · 2016-10-17T20:29:16Z

@espg
Try the following to install the patched version available in this PR:

pip3 install --upgrade git+https://github.com/caethan/line_profiler

espg · 2016-10-17T20:33:15Z

@gforsyth no dice:

~ ➤ pip3 install --upgrade git+https://github.com/caethan/line_profiler
Collecting git+https://github.com/caethan/line_profiler
Cloning https://github.com/caethan/line_profiler to /tmp/pip-dkkb048l-build
Installing collected packages: line-profiler
Found existing installation: line-profiler 1.0
Uninstalling line-profiler-1.0:
Successfully uninstalled line-profiler-1.0
Running setup.py install for line-profiler ... done
Successfully installed line-profiler-1.0
~ ➤ ipython
Python 3.5.2 (default, Sep 29 2016, 18:13:17)
Type "copyright", "credits" or "license" for more information.

IPython 5.1.0 -- An enhanced Interactive Python.
? -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help -> Python's own help system.
object? -> Details about 'object', use 'object??' for extra details.
[TerminalIPythonApp] WARNING | Error in loading extension: line_profiler_ext
Check your config files in /Users/grigsbye/.ipython/profile_default
Traceback (most recent call last):
File "/usr/local/lib/python3.5/site-packages/IPython/core/shellapp.py", line 246, in init_extensions
self.shell.extension_manager.load_extension(ext)
File "/usr/local/lib/python3.5/site-packages/IPython/core/extensions.py", line 85, in load_extension
if self._call_load_ipython_extension(mod):
File "/usr/local/lib/python3.5/site-packages/IPython/core/extensions.py", line 132, in _call_load_ipython_extension
mod.load_ipython_extension(self.shell)
File "/Users/grigsbye/.ipython/extensions/line_profiler_ext.py", line 4, in load_ipython_extension
ip.define_magic('lprun', line_profiler.magic_lprun)
AttributeError: 'TerminalInteractiveShell' object has no attribute 'define_magic'

gforsyth · 2016-10-17T20:45:41Z

Hey @espg -- it looks like pip3 isn't pointing to the python install where ipython lives. I don't want to pollute this thread with a bunch of troubleshooting but if you want to drop into https://tlk.io/line_profiler I'm happy to walk you through figuring it out.

danielballan · 2016-10-17T20:54:14Z

@espg That error message ("no attribute 'define_magic') suggests that your ipython is still not finding the version of the code in this PR, which replaces define_magic with the new IPython magics API. Perhaps your ipython and your pip are in different environments.

I second @jakirkham's offer to help -- I'd be willing to do the release if that helps get this out the door and restore compatibility with IPython stable.

caethan · 2016-10-17T21:37:05Z

Talked with @espg and found the problem: He had a custom extension that tried to load in the magic command using define_magic. Fixed it to use the new method. Apparently scikit-learn suggested this method in some of their documentation, so I should submit a pull request to fix it once this pull request gets merged.

takluyver · 2016-10-19T11:13:52Z

Possibly someone should ask @rkern for access to make new releases - or even maintain a fork, if Robert has gone awol.

caethan · 2016-10-20T15:12:51Z

Talked to @rkern offline and he's going to transfer maintenance responsibility over to me, so we should be able to get this released properly before too long.

takluyver · 2016-10-20T15:22:26Z

Thanks @caethan :-)

…dd [email protected] as maintainer

caethan · 2016-10-20T21:04:43Z

Merged in here - will announce on this thread once I get maintainer access to PyPi and 2.0 is released there.

caethan · 2016-10-20T21:23:58Z

2.0 is released on PyPi with this fix. Enjoy and be merry!

gabereiser · 2016-10-20T21:39:08Z

👍 this has bit me today and ended up here only to find the interwebs haven't caught up with this fix.

wesm · 2016-10-20T21:55:26Z

thank you!

Update for compatibility with IPython 5.0

677a431

Also tested with IPython 4.1.1. Replaces the depreciated ip.define_magic() method with ip.register_magics() and some modifications to handle the different API required.

This was referenced Jul 12, 2016

IPython 5.0 (forthcoming) seems to have removed an API the line_profiler extension needs #62

Closed

%lprun will break as of IPython 5.0 #61

Closed

Brett Olsen added 2 commits July 12, 2016 10:40

Add ipython as a hard dependency

a107df5

The new magic decorators need ipython imported at a module level

Move Cython install options into the requirements file

69c5e2b

tguillemot reviewed Jul 16, 2016
View reviewed changes

thomasaarholt mentioned this pull request Jul 19, 2016

NameError: name 'profile' is not defined #53

Closed

Update for travis build

482772a

patricksnape mentioned this pull request Sep 9, 2016

BUG: Switched to new way of registering ipython magics #68

Closed

mbatchkarov mentioned this pull request Oct 19, 2016

%load_ext line_profiler raises AttributeError jupyter/notebook#1844

Closed

Brett Olsen added 4 commits October 20, 2016 12:54

Update version to 2.0, include IPython >=0.13 as a hard dependency, a…

fcdba72

…dd [email protected] as maintainer

Remove check for (unsupported) earlier IPython versions

a82d7e3

Fixes for travis build (special case Cython install)

ff09c4d

Clean up README and update makefile

516a214

caethan merged commit d3cef04 into rkern:master Oct 20, 2016

TomDLT mentioned this pull request Oct 21, 2016

[MRG + 1] Update docs with new line_profiler signature and extension method scikit-learn/scikit-learn#7715

Closed

sagetrac-tmonteil mannequin mentioned this pull request Aug 27, 2019

line_profiler is broken after IPython 5.0 upgrade sagemath/sage#21457

Closed

Update for compatibility with IPython 5.0 #65

Update for compatibility with IPython 5.0 #65

Uh oh!

Conversation

caethan commented Jul 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wholmgren commented Jul 12, 2016

Uh oh!

tguillemot commented Jul 16, 2016

Uh oh!

tguillemot Jul 16, 2016

Choose a reason for hiding this comment

Uh oh!

tguillemot commented Jul 16, 2016

Uh oh!

jingkungao commented Jul 31, 2016

Uh oh!

caethan commented Aug 12, 2016

Uh oh!

danielballan commented Aug 15, 2016

Uh oh!

cancan101 commented Aug 24, 2016

Uh oh!

caethan commented Aug 30, 2016

Uh oh!

esafak commented Aug 31, 2016

Uh oh!

caethan commented Sep 2, 2016

Uh oh!

tguillemot commented Sep 2, 2016

Uh oh!

patricksnape commented Sep 9, 2016

Uh oh!

wesm commented Sep 12, 2016

Uh oh!

caethan commented Sep 15, 2016

Uh oh!

alimuldal commented Sep 18, 2016

Uh oh!

wesm commented Sep 29, 2016

Uh oh!

espg commented Oct 15, 2016

Uh oh!

danielballan commented Oct 15, 2016

Uh oh!

jakirkham commented Oct 17, 2016

Uh oh!

espg commented Oct 17, 2016

Uh oh!

gforsyth commented Oct 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

espg commented Oct 17, 2016

Uh oh!

gforsyth commented Oct 17, 2016

Uh oh!

danielballan commented Oct 17, 2016

Uh oh!

caethan commented Oct 17, 2016

Uh oh!

takluyver commented Oct 19, 2016

Uh oh!

caethan commented Oct 20, 2016

Uh oh!

takluyver commented Oct 20, 2016

Uh oh!

caethan commented Oct 20, 2016

Uh oh!

caethan commented Oct 20, 2016

Uh oh!

gabereiser commented Oct 20, 2016

Uh oh!

wesm commented Oct 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

caethan commented Jul 12, 2016 •

edited

Loading

gforsyth commented Oct 17, 2016 •

edited

Loading