Skip to content

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Feb 17, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

Misc improvements

  • Now we can see the correct exit code of programs
  • When using dev mode, the expected cli args will be printed in risedev.log
  • Better error message

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh requested a review from BowenXiao1999 February 17, 2022 04:05
@github-actions github-actions bot added the type/feature Type: New feature. label Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #382 (1e0a00e) into main (a203f43) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #382   +/-   ##
=========================================
  Coverage     74.55%   74.55%           
  Complexity     2681     2681           
=========================================
  Files           866      866           
  Lines         49188    49188           
  Branches       1591     1591           
=========================================
  Hits          36674    36674           
  Misses        11701    11701           
  Partials        813      813           
Flag Coverage Δ
java 62.00% <ø> (ø)
rust 79.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/stream/src/executor/barrier_align.rs 78.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a203f43...1e0a00e. Read the comment docs.

@skyzh skyzh requested a review from wcy-fdu February 17, 2022 05:05
Copy link
Contributor

@wcy-fdu wcy-fdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcy-fdu wcy-fdu merged commit 5b22073 into main Feb 17, 2022
@wcy-fdu wcy-fdu deleted the skyzh/riselab-dev-better branch February 17, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants