feat(optimizer): condition && join predicate #367
Conversation
Codecov Report
@@ Coverage Diff @@
## main #367 +/- ##
============================================
+ Coverage 74.23% 74.41% +0.17%
Complexity 2681 2681
============================================
Files 863 868 +5
Lines 48830 49269 +439
Branches 1591 1591
============================================
+ Hits 36250 36664 +414
- Misses 11767 11792 +25
Partials 813 813
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Please write a proper PR description, following the pull_request_template |
| /// ``` | ||
| /// will call the `create` function with left_colsnum = 2 and on_clause is (supposed input_ref | ||
| /// count start from 0) | ||
| /// ```sql |
There was a problem hiding this comment.
(it is just pass the doc test
| use crate::utils::Condition; | ||
| #[derive(Debug, Clone)] | ||
| /// the join predicate used in optimizer | ||
| pub struct EqJoinPredicate { |
There was a problem hiding this comment.
Why this is called EqJoinPredicate? So at least it contains one equal preidcate?
Do we have NeqJoinPredicate? etc.
There was a problem hiding this comment.
this is just for equal join which has equal join and used for hashjoin and sortMergeJoin to easily get the eq and noneq condition. for the non eq join, the condition is enough.
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)
#106