Skip to content

feat(batch): temporarily add min/max for bool required by current frontend for tpch #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2022
Merged

feat(batch): temporarily add min/max for bool required by current frontend for tpch #362

merged 2 commits into from
Feb 16, 2022

Conversation

@xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Feb 16, 2022 •
edited
Loading

What's changed and what's your intention?

#154

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/feature Type: New feature. label Feb 16, 2022
@xiangjinwu xiangjinwu marked this pull request as ready for review February 16, 2022 08:36
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #362 (83f5c64) into main (1a782ce) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #362      +/-   ##
============================================
+ Coverage     74.23%   74.27%   +0.04%     
  Complexity     2681     2681              
============================================
  Files           863      863              
  Lines         48845    48934      +89     
  Branches       1591     1591              
============================================
+ Hits          36262    36348      +86     
- Misses        11770    11773       +3     
  Partials        813      813
Flag Coverage Δ
java 62.00% <ø> (ø)
rust 79.54% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/common/src/vector_op/agg/general_agg.rs 97.03% <ø> (ø)
...t/common/src/vector_op/agg/general_distinct_agg.rs 74.48% <ø> (ø)
rust/common/src/vector_op/agg/aggregator.rs 93.47% <100.00%> (ø)
rust/meta/src/storage/sled_metastore.rs 96.33% <0.00%> (-0.44%) ⬇️
rust/meta/src/storage/metastore.rs 94.40% <0.00%> (-0.08%) ⬇️
rust/meta/src/storage/tests.rs 100.00% <0.00%> (ø)
rust/stream/src/executor/barrier_align.rs 78.78% <0.00%> (ø)
rust/meta/src/hummock/model/current_version_id.rs 100.00% <0.00%> (ø)
rust/common/src/types/ordered_float.rs 25.82% <0.00%> (+0.33%) ⬆️
rust/meta/src/model/mod.rs 80.00% <0.00%> (+0.93%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a782ce...83f5c64. Read the comment docs.

@liurenjie1024 liurenjie1024 merged commit 557a17e into main Feb 16, 2022
@liurenjie1024 liurenjie1024 deleted the rust-batch-agg-bool branch February 16, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xiangjinwu @liurenjie1024