Skip to content

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Feb 14, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

part of #297

@github-actions github-actions bot added the type/feature Type: New feature. label Feb 14, 2022
@wyhyhyhyh
Copy link
Contributor

:cxs

Copy link
Contributor

@wyhyhyhyh wyhyhyhyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skyzh skyzh enabled auto-merge (squash) February 14, 2022 09:19
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #299 (75241b7) into main (0f11894) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #299   +/-   ##
=========================================
  Coverage     74.14%   74.14%           
  Complexity     2665     2665           
=========================================
  Files           850      850           
  Lines         48107    48107           
  Branches       1586     1586           
=========================================
+ Hits          35668    35669    +1     
+ Misses        11627    11626    -1     
  Partials        812      812           
Flag Coverage Δ
java 61.93% <ø> (ø)
rust 79.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/stream/src/executor/barrier_align.rs 78.78% <0.00%> (ø)
rust/meta/src/hummock/compaction.rs 23.97% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f11894...75241b7. Read the comment docs.

@skyzh skyzh merged commit 8976971 into main Feb 14, 2022
@skyzh skyzh deleted the skyzh/dashboard-multi-actor branch February 14, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants