Skip to content

feat: release a worker node's hummock resources when it is deleted. #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 14, 2022
Merged

feat: release a worker node's hummock resources when it is deleted. #292

merged 4 commits into from
Feb 14, 2022

Conversation

@zwang28
Copy link
Contributor

@zwang28 zwang28 commented Feb 14, 2022 •
edited
Loading

What's changed and what's your intention?

When ClusterManager removes a worker node, it is made to notify HummockManager. HummockManager will then release Hummock resources pinned by that worker node.
NodeId in ClusterManager is used as the HummockContextId in HummockManager, which is a handle for some pinned Hummock resources.

Checklist

  • I have added necessary unit tests

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/feature Type: New feature. label Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022 •
edited
Loading

Codecov Report

Merging #292 (5797710) into main (8976971) will increase coverage by 0.02%.
The diff coverage is 77.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #292      +/-   ##
============================================
+ Coverage     74.33%   74.35%   +0.02%     
  Complexity     2665     2665              
============================================
  Files           854      854              
  Lines         48189    48271      +82     
  Branches       1586     1586              
============================================
+ Hits          35822    35893      +71     
- Misses        11555    11566      +11     
  Partials        812      812
Flag Coverage Δ
java 61.93% <ø> (ø)
rust 79.71% <77.11%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/hummock/compaction.rs 63.69% <ø> (-0.69%) ⬇️
rust/storage/src/hummock/hummock_meta_client.rs 0.00% <0.00%> (ø)
rust/storage/src/hummock/mod.rs 40.36% <ø> (ø)
rust/meta/src/rpc/service/hummock_service.rs 1.26% <10.00%> (+0.04%) ⬆️
rust/meta/src/cluster/mod.rs 63.82% <22.22%> (-8.68%) ⬇️
...orage/src/hummock/mock/mock_hummock_meta_client.rs 54.83% <50.00%> (ø)
rust/meta/src/hummock/hummock_manager.rs 75.08% <90.90%> (+1.23%) ⬆️
rust/meta/src/hummock/hummock_manager_tests.rs 95.43% <92.64%> (-1.19%) ⬇️
rust/meta/src/rpc/server.rs 90.00% <100.00%> (ø)
rust/meta/src/stream/scheduler.rs 94.28% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8976971...5797710. Read the comment docs.

@zwang28 zwang28 marked this pull request as ready for review February 14, 2022 08:44
@zwang28 zwang28 requested a review from yezizp2012 February 14, 2022 08:47
yezizp2012
yezizp2012 approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang28 zwang28 enabled auto-merge (squash) February 14, 2022 09:53
@zwang28 zwang28 merged commit 5766ebb into main Feb 14, 2022
@zwang28 zwang28 deleted the wangzheng/feat_release_hummock_resource branch February 14, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yezizp2012 yezizp2012 yezizp2012 approved these changes

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zwang28 @yezizp2012