Skip to content

Conversation

@fuyufjh
Copy link
Collaborator

@fuyufjh fuyufjh commented Feb 10, 2022

What's changed and what's your intention?

Support parallel source, especially the table source V2. After this PR:

image

(Waiting for E2E to see whether Kafka source works...)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Closes #111

@github-actions github-actions bot added the type/feature Type: New feature. label Feb 10, 2022
// Currently, we assume the parallel degree is at least 4, and grows linearly with
// more worker nodes added.
max(self.worker_count * 2, PARALLEL_DEGREE_LOW_BOUND)
} else {
Copy link
Member

@yezizp2012 yezizp2012 Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will set source parallel degree same to others in the middle. Previously the source degree is set to worker count, @wyhyhyhyh added a logic to make them round robin at every worker node. You may need to fix the test test_fragmenter_case2 in test_fragmenter.rs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my understanding, for table V2, source degree is not necessary equivalent with worker count. But anyway source has to be coherent with the MV number, and colocated with MV if necessary?

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fuyufjh fuyufjh marked this pull request as draft February 11, 2022 01:54
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #232 (a18c607) into main (89585eb) will decrease coverage by 0.00%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #232      +/-   ##
============================================
- Coverage     74.08%   74.07%   -0.01%     
  Complexity     2665     2665              
============================================
  Files           850      850              
  Lines         48083    48079       -4     
  Branches       1584     1584              
============================================
- Hits          35622    35616       -6     
- Misses        11651    11653       +2     
  Partials        810      810              
Flag Coverage Δ
java 61.94% <ø> (ø)
rust 79.33% <93.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/server/tests/table_v2_materialize.rs 95.04% <ø> (ø)
rust/source/src/lib.rs 75.00% <ø> (ø)
rust/meta/src/stream/fragmenter.rs 87.09% <50.00%> (-2.16%) ⬇️
rust/stream/src/executor/stream_source.rs 84.53% <50.00%> (ø)
rust/batch/src/executor/insert.rs 85.88% <100.00%> (ø)
rust/meta/src/stream/graph/fragment_graph.rs 100.00% <100.00%> (ø)
rust/meta/src/stream/test_fragmenter.rs 98.58% <100.00%> (+0.03%) ⬆️
rust/source/src/table_v2.rs 91.52% <100.00%> (-1.02%) ⬇️
rust/stream/src/task/stream_manager.rs 52.33% <100.00%> (+0.11%) ⬆️
rust/stream/src/executor/barrier_align.rs 78.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89585eb...a18c607. Read the comment docs.

@fuyufjh fuyufjh marked this pull request as ready for review February 13, 2022 08:01
@fuyufjh fuyufjh merged commit a79c055 into main Feb 13, 2022
@fuyufjh fuyufjh deleted the eric/parallel-source branch February 13, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support parallel source

7 participants