Skip to content

feat(type): remove prec and scale in Decimal #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2022
Merged

feat(type): remove prec and scale in Decimal #175

merged 1 commit into from
Feb 10, 2022

Conversation

@likg227
Copy link
Contributor

@likg227 likg227 commented Feb 9, 2022 •
edited
Loading

What's changed and what's your intention?

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@likg227 likg227 requested a review from fuyufjh February 9, 2022 10:27
@github-actions github-actions bot added the type/feature Type: New feature. label Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #175 (36dd0bd) into main (d50ef70) will decrease coverage by 0.23%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #175      +/-   ##
============================================
- Coverage     74.65%   74.41%   -0.24%     
  Complexity     2654     2654              
============================================
  Files           834      838       +4     
  Lines         47883    47824      -59     
  Branches       1562     1562              
============================================
- Hits          35747    35590     -157     
- Misses        11337    11435      +98     
  Partials        799      799
Flag Coverage Δ
java 62.08% <ø> (ø)
rust 79.74% <85.71%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/batch/src/executor/insert.rs 85.77% <ø> (ø)
rust/common/src/expr/expr_binary_nullable.rs 51.61% <ø> (+0.09%) ⬆️
rust/common/src/expr/expr_unary.rs 63.44% <0.00%> (+1.33%) ⬆️
rust/source/src/manager.rs 97.65% <ø> (ø)
rust/source/src/parser/common.rs 74.07% <0.00%> (ø)
rust/source/src/parser/protobuf_parser.rs 84.00% <ø> (-0.08%) ⬇️
rust/storage/src/bummock/table.rs 81.25% <ø> (ø)
.../src/executor/managed_state/aggregation/extreme.rs 81.32% <0.00%> (-0.26%) ⬇️
rust/common/src/types/mod.rs 67.79% <60.00%> (-0.62%) ⬇️
rust/batch/src/executor/seq_scan.rs 85.91% <100.00%> (ø)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50ef70...36dd0bd. Read the comment docs.

@likg227 likg227 requested a review from xiangjinwu February 10, 2022 01:53
@likg227 likg227 merged commit 397ccd7 into main Feb 10, 2022
@likg227 likg227 deleted the lkg/remove-decimal-member branch February 10, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangjinwu xiangjinwu xiangjinwu approved these changes

@fuyufjh fuyufjh Awaiting requested review from fuyufjh

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@likg227 @xiangjinwu