fix(frontend): use original string for BigDecimal instead of parseDouble #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
=========================================
Coverage 74.46% 74.46%
- Complexity 2653 2654 +1
=========================================
Files 833 833
Lines 47824 47824
Branches 1562 1562
=========================================
+ Hits 35610 35611 +1
+ Misses 11415 11414 -1
Partials 799 799
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
20bb0ea to
3a394c5
Compare
fuyufjh
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
create table t1(v1 numeric);insert into t1 values (1.23), (1.20), (1.00);select * from t1Previously, it returns 1.23, 1.2, 1.0;
Now, it return 1.23, 1.20, 1.00.
This blocks tpch q18.
1in the query of tpch q10 is changed to1.00due to reasons in #135. Batch's q10 has a manually addedround, so may leave it for now.Checklist
Refer to a related PR or issue link (optional)
closes #115