fix(batch): use shuffle aggregation for distinct aggregation #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67dc07f to
1fc29ee
Compare
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
============================================
- Coverage 74.54% 74.46% -0.09%
- Complexity 2645 2653 +8
============================================
Files 832 833 +1
Lines 47823 47824 +1
Branches 1560 1562 +2
============================================
- Hits 35651 35611 -40
- Misses 11374 11414 +40
- Partials 798 799 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
As #121 describes, aggregation with
distinctcannot be processed in the two-phase fashion.Refer to a related PR or issue link (optional)
closes #121