Skip to content

feat(optimizer): use fixedbitset instead of bit-set #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2022
Merged

feat(optimizer): use fixedbitset instead of bit-set #114

merged 2 commits into from
Feb 7, 2022

Conversation

@st1page
Copy link
Contributor

@st1page st1page commented Feb 7, 2022

use fixedbitset instead of bit-set which is

  • has more function
  • more suitable for us (Panics if bit is out of bounds).

@github-actions github-actions bot added the type/feature Type: New feature. label Feb 7, 2022
@st1page st1page requested review from fuyufjh and xiangjinwu February 7, 2022 08:55
fuyufjh
fuyufjh approved these changes Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@st1page st1page enabled auto-merge (squash) February 7, 2022 09:02
@st1page st1page merged commit 68f33b7 into main Feb 7, 2022
@st1page st1page deleted the sts/use_fixedbitset_in_optimizer branch February 7, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuyufjh fuyufjh fuyufjh approved these changes

@xiangjinwu xiangjinwu Awaiting requested review from xiangjinwu

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@st1page @fuyufjh