Skip to content

feat(frontend): add Trim support #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 21, 2022
Merged

feat(frontend): add Trim support #1114

merged 10 commits into from
Mar 21, 2022

Conversation

@mczhuang
Copy link
Contributor

@mczhuang mczhuang commented Mar 21, 2022 •
edited
Loading

What's changed and what's your intention?

**As title, and add more tests for #734 **

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/feature Type: New feature. label Mar 21, 2022
skyzh
skyzh reviewed Mar 21, 2022
View reviewed changes
@mczhuang mczhuang requested a review from neverchanje March 21, 2022 08:06
neverchanje
neverchanje approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mczhuang mczhuang merged commit 38d1678 into main Mar 21, 2022
@mczhuang mczhuang deleted the mczhuang/bind branch March 21, 2022 10:14
pangzhenzhou pushed a commit that referenced this pull request Mar 28, 2022
@mczhuang
feat(frontend): add Trim support (#1114)
3011726 
* Merge branch 'main' of https://github.com/singularity-data/risingwave-dev into mczhuang/bind_func

* merge conflicts

* fix duplicate merge

* fix

* fix github error

* fix

* add like test

* format check

* remove create table in test sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@skyzh skyzh skyzh left review comments

@neverchanje neverchanje neverchanje approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mczhuang @skyzh @neverchanje