feat(frontend): add stream proto test #1105
Merged
+342
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi <[email protected]>
BugenZhao
reviewed
Mar 21, 2022
Signed-off-by: Alex Chi <[email protected]>
fuyufjh
approved these changes
Mar 21, 2022
|
|
||
| // Only generate batch_plan if it is specified in test case | ||
| if self.batch_plan.is_some() { | ||
| ret.batch_plan = Some(explain_plan(&batch_plan)); |
Collaborator
There was a problem hiding this comment.
IIUC, the proto of batch plan contains the information of exchange source (node IP & port), so it's not possible to test it?
Contributor
Author
There was a problem hiding this comment.
We always run it with our own test runner, so we can get a consistent result by manually setting the IPs when creating the mock compute nodes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Chi [email protected]
What's changed and what's your intention?
As frontend ./risedev p cannot start for now (see #1093), I'd like to compare the generated proto with the java frontend to ensure that create MV statements are producing nearly the same proto as before. Therefore, I added
stream_prototest.Checklist
Refer to a related PR or issue link (optional)