Skip to content

feat(udf): allow to ignore "language" in create function statements #10608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2023
Merged

feat(udf): allow to ignore "language" in create function statements #10608

merged 1 commit into from
Jun 29, 2023
+37 −49

Conversation

@wangrunji0408
Copy link
Contributor

@wangrunji0408 wangrunji0408 commented Jun 28, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Currently users are required to specify the language in create function statements. But actually it is unnecessary in external function approach. So this PR makes the language an optional field. If specified, it will be ignored for compatibility.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

The language parameter is no longer required in create function statements.

@github-actions github-actions bot added type/chore user-facing-changes Contains changes that are visible to users labels Jun 28, 2023
@wangrunji0408 wangrunji0408 changed the title chore(udf): allow to ignore "language" in create function statements feat(udf): allow to ignore "language" in create function statements Jun 28, 2023
@github-actions github-actions bot added type/feature Type: New feature. and removed type/chore labels Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023 •
edited
Loading

Codecov Report

Merging #10608 (a125b4c) into main (f3ed466) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #10608   +/-   ##
=======================================
  Coverage   70.24%   70.24%           
=======================================
  Files        1274     1274           
  Lines      219182   219174    -8     
=======================================
- Hits       153972   153967    -5     
+ Misses      65210    65207    -3
Flag Coverage Δ
rust 70.24% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/create_function.rs 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

xxchan
xxchan reviewed Jun 28, 2023
View reviewed changes
src/frontend/src/handler/create_function.rs
Copy link
Collaborator

@xxchan xxchan Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about something like language external?

Copy link
Collaborator

@xxchan xxchan Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm considering is USING LINK enough to distinguish external function with e.g., SQL UDF, WASM UDF. And specifying the type explicitly might be better.

Copy link
Contributor Author

@wangrunji0408 wangrunji0408 Jun 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think language external can be inferred from using link. 🤔
As SQL UDF and WASM UDF will be executed inside kernel, they are not likely to have using links.

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Jun 29, 2023
Merged via the queue into main with commit d347047 Jun 29, 2023
@wangrunji0408 wangrunji0408 deleted the wrj/ignore-language branch June 29, 2023 09:50
@emile-00 emile-00 mentioned this pull request Jul 11, 2023
Closed
@emile-00 emile-00 added the 📖✓ Covered or will be covered in the user docs. label Jul 11, 2023
@CharlieSYH CharlieSYH mentioned this pull request Aug 21, 2023
Merged
2 tasks
@TennyZhuang TennyZhuang mentioned this pull request Aug 22, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xxchan xxchan xxchan approved these changes

@neverchanje neverchanje Awaiting requested review from neverchanje

@TennyZhuang TennyZhuang Awaiting requested review from TennyZhuang

Assignees

No one assigned

Labels

type/feature Type: New feature. user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wangrunji0408 @xxchan @emile-00