feat(meta): handling duplicated mv creation in create mv service v2 #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bowen Zhou <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1066 +/- ##
============================================
- Coverage 71.76% 71.69% -0.08%
Complexity 2766 2766
============================================
Files 996 996
Lines 84016 84100 +84
Branches 1790 1790
============================================
+ Hits 60293 60294 +1
- Misses 22832 22915 +83
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
yezizp2012
reviewed
Mar 18, 2022
| Ok(version) | ||
| } | ||
|
|
||
| async fn create_materialized_view_inner( |
Member
There was a problem hiding this comment.
how about change create_mview_in_stream_manager to create_materialized_view_inner, and call create_materialized_view_inner directly in create_materialized_view to make it simple.
…o zbw/create-mview-v2-refactor
yezizp2012
reviewed
Mar 18, 2022
Member
|
Good job, plz help to handle |
Signed-off-by: Bowen Zhou <[email protected]>
Signed-off-by: Bowen Zhou <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bowen Zhou [email protected]
What's changed and what's your intention?
As title. This PR separates mv creation in catalog manager into two parts:
Noted that we should also refactor
create_sourceaccording to this.Checklist
Refer to a related PR or issue link (optional)
Resolve #1019.
Maybe we should merge #1065 first