Skip to content

feat: update downstream actor ids when create MoM #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2022
Merged

feat: update downstream actor ids when create MoM #1041

merged 4 commits into from
Mar 17, 2022

Conversation

@yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Mar 17, 2022 •
edited
Loading

What's changed and what's your intention?

As title, update downstream_actor_ids in sink node of depented materialized view when create MoM. This is necessary when rebuild whole materialized views in the cluster.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@yezizp2012 yezizp2012 requested review from BugenZhao and MrCroxx March 17, 2022 10:53
@github-actions github-actions bot added the type/feature Type: New feature. label Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited
Loading

Codecov Report

Merging #1041 (d400d1d) into main (4db91cf) will decrease coverage by 0.03%.
The diff coverage is 9.37%.

@@             Coverage Diff              @@
##               main    #1041      +/-   ##
============================================
- Coverage     71.45%   71.41%   -0.04%     
  Complexity     2766     2766              
============================================
  Files           980      980              
  Lines         57862    57893      +31     
  Branches       1790     1790              
============================================
+ Hits          41343    41345       +2     
- Misses        15628    15657      +29     
  Partials        891      891
Flag Coverage Δ
java 61.03% <ø> (ø)
rust 75.33% <9.37%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/model/stream.rs 72.05% <ø> (ø)
rust/meta/src/stream/meta.rs 40.00% <0.00%> (-7.06%) ⬇️
rust/meta/src/barrier/command.rs 35.29% <6.66%> (-7.30%) ⬇️
rust/meta/src/stream/graph/stream_graph.rs 44.82% <100.00%> (+0.31%) ⬆️
rust/meta/src/stream/stream_manager.rs 74.10% <100.00%> (+0.10%) ⬆️
rust/meta/src/hummock/compaction.rs 78.68% <0.00%> (-0.55%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

BugenZhao
BugenZhao approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long expected!

@yezizp2012 yezizp2012 enabled auto-merge (squash) March 17, 2022 12:24
@yezizp2012 yezizp2012 merged commit 070f28d into main Mar 17, 2022
@yezizp2012 yezizp2012 deleted the feat/mom-update-upstream branch March 17, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

@MrCroxx MrCroxx Awaiting requested review from MrCroxx

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yezizp2012 @BugenZhao