Skip to content

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 17, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title. Currently we are using my modified patch. Will migrate to the upstream if it gets merged.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

upstream PR taiki-e/cargo-llvm-cov#144
close #1027

Signed-off-by: Alex Chi <[email protected]>
@github-actions github-actions bot added the type/feature Type: New feature. label Mar 17, 2022
skyzh added 5 commits March 18, 2022 07:51
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #1048 (a25e279) into main (53a2f42) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1048      +/-   ##
============================================
+ Coverage     71.46%   71.85%   +0.39%     
  Complexity     2766     2766              
============================================
  Files           980      990      +10     
  Lines         58051    83323   +25272     
  Branches       1790     1790              
============================================
+ Hits          41484    59869   +18385     
- Misses        15676    22563    +6887     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 74.39% <100.00%> (-0.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/batch/src/lib.rs 100.00% <ø> (ø)
rust/batch/src/rpc/service/task_service.rs 0.00% <ø> (ø)
rust/compute/src/lib.rs 4.34% <ø> (+4.34%) ⬆️
rust/compute/src/rpc/service/exchange_service.rs 0.00% <ø> (ø)
rust/compute/src/rpc/service/stream_service.rs 0.00% <ø> (ø)
rust/meta/src/lib.rs 2.32% <ø> (+2.32%) ⬆️
rust/meta/src/rpc/service/catalog_service.rs 91.78% <ø> (-8.22%) ⬇️
rust/meta/src/rpc/service/epoch_service.rs 27.27% <ø> (-72.73%) ⬇️
rust/meta/src/rpc/service/heartbeat_service.rs 84.61% <ø> (-15.39%) ⬇️
rust/meta/src/rpc/service/notification_service.rs 93.33% <ø> (-6.67%) ⬇️
... and 544 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: Alex Chi <[email protected]>
@skyzh
Copy link
Contributor Author

skyzh commented Mar 18, 2022

doctests are not running. Let's fix it later.

@skyzh
Copy link
Contributor Author

skyzh commented Mar 18, 2022

The way tarpaulin and LLVM cov calculates covered lines seem different, so we see some large diff in coverage. But this shall not be a problem.

@TennyZhuang
Copy link
Contributor

LSTM!

@skyzh skyzh enabled auto-merge (squash) March 18, 2022 01:15
@TennyZhuang
Copy link
Contributor

unit test in 3 mins, it blazing fast!

@skyzh skyzh merged commit 2340a27 into main Mar 18, 2022
@skyzh skyzh deleted the skyzh/nextest branch March 18, 2022 01:17
@MrCroxx MrCroxx mentioned this pull request Mar 18, 2022
2 tasks
pangzhenzhou pushed a commit that referenced this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: slow unit test

3 participants