chore: improve PR template checklist #10274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
commented
Jun 9, 2023
Comment on lines
-30
to
+33
| body: 'My PR \*\*DOES NOT\*\* contain user-facing changes' | ||
| body: 'My PR contains user-facing changes' | ||
| - label: "user-facing-changes" | ||
| body: '- \[x\] My PR contains user-facing changes' |
Collaborator
Author
There was a problem hiding this comment.
I'm inspired when I see @yezizp2012 changed DOES NOT to DOES in #10269 🤣
lmatz
approved these changes
Jun 10, 2023
Little-Wallace
pushed a commit
that referenced
this pull request
Jun 12, 2023
lmatz
pushed a commit
that referenced
this pull request
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The template is a little weird. I think one reason is that previously all tasks need to be ticked. Now this is not required to merge a PR and I think making some changes can make it more natural.
Checklist
./risedev check(or alias,./risedev c)Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note