Skip to content

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Feb 7, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

MinIO would still be in the state of uninitialized even when health port probes 200 OK. This PR fixes this by retrying.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh requested a review from likg227 February 7, 2022 04:11
@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #97 (bffdc77) into main (0a8836b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #97   +/-   ##
=========================================
  Coverage     74.40%   74.40%           
  Complexity     2645     2645           
=========================================
  Files           829      829           
  Lines         47563    47563           
  Branches       1560     1560           
=========================================
  Hits          35389    35389           
  Misses        11376    11376           
  Partials        798      798           
Flag Coverage Δ
java 61.91% <ø> (ø)
rust 79.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/hummock/compaction.rs 73.85% <0.00%> (-0.66%) ⬇️
rust/storage/src/hummock/version_manager.rs 39.18% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8836b...bffdc77. Read the comment docs.

@skyzh skyzh merged commit c6c3c7b into main Feb 7, 2022
@skyzh skyzh deleted the skyzh/fix-minio-check branch February 7, 2022 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants