feat(risedev): use hummock in-memory mode by default #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
BugenZhao
reviewed
Mar 16, 2022
Comment on lines
+37
to
+39
| if !path.exists() { | ||
| return Err(anyhow!("etcd binary not found in {:?}\nDid you enable etcd feature in `./risedev configure`?", path)); | ||
| } |
Codecov Report
@@ Coverage Diff @@
## main #954 +/- ##
============================================
- Coverage 71.85% 71.77% -0.08%
Complexity 2766 2766
============================================
Files 970 970
Lines 56600 56656 +56
Branches 1787 1787
============================================
- Hits 40668 40665 -3
- Misses 15042 15101 +59
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
BugenZhao
approved these changes
Mar 16, 2022
This was referenced Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Checklist
Refer to a related PR or issue link (optional)
close #34