feat(frontend): show if system parameters are mutable #9526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gun9niR
commented
Apr 28, 2023
Comment on lines
+39
to
+48
| { barrier_interval_ms, u32, Some(1000_u32), false }, | ||
| { checkpoint_frequency, u64, Some(10_u64), true }, | ||
| { sstable_size_mb, u32, Some(256_u32), false }, | ||
| { block_size_kb, u32, Some(64_u32), false }, | ||
| { bloom_false_positive, f64, Some(0.001_f64), false }, | ||
| { state_store, String, None, false }, | ||
| { data_directory, String, None, false }, | ||
| { backup_storage_url, String, Some("memory".to_string()), false }, | ||
| { backup_storage_directory, String, Some("backup".to_string()), false }, | ||
| { telemetry_enabled, bool, Some(true), true }, |
Contributor
Author
There was a problem hiding this comment.
I can't use const MUTABLE/IMMUTABLE here, because if for_all_undeprecated_params are used in other crates, they need to be imported as well, which seems unintuitive.
Codecov Report
@@ Coverage Diff @@
## main #9526 +/- ##
==========================================
- Coverage 70.75% 70.75% -0.01%
==========================================
Files 1232 1232
Lines 206264 206276 +12
==========================================
+ Hits 145948 145954 +6
- Misses 60316 60322 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title. Closes #9505
Checklist For Contributors
./risedev check(or alias,./risedev c)Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
SHOW PARAMETERSwill display system parameters' mutability.