-
Notifications
You must be signed in to change notification settings - Fork 705
feat: add support for encode&decode #9351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you help enable the test cases here:
|
|
Seems like an error happend in compile-time which cast expr bind error. |
I see that the cast function [varchar->bytea] was already implemented here https://github.com/risingwavelabs/risingwave/blob/main/src/expr/src/vector_op/cast.rs#L196 So I fix it by simple add Bytea type to CAST_MAP, see commit:432b705 |
xiangjinwu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. And your fix to the CAST_MAP is correct.
src/tests/regress/data/sql/strings.sql
|
After I changed the CAST_MAP, I should also modify the e2e_test/batch/catalog/pg_cast.slt.part, which the catalog was Finally, all the test was passsed now🥳. |
lmatz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your contribution!
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
According to #8937.
The encode and decode function are implemented in this pull request.
Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note