Skip to content

feat: use inner message #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2022
Merged

feat: use inner message #932

merged 1 commit into from
Mar 15, 2022

Conversation

@shanicky
Copy link
Contributor

@shanicky shanicky commented Mar 15, 2022 •
edited
Loading

Signed-off-by: Peng Chen [email protected]

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/feature Type: New feature. label Mar 15, 2022
@shanicky
feat: use inner message
3546434 
Signed-off-by: Peng Chen <[email protected]>
@shanicky shanicky force-pushed the peng/new-reader-next-api branch from 1631797 to 3546434 Compare March 15, 2022 09:14
@shanicky shanicky enabled auto-merge (squash) March 15, 2022 09:15
pangzhenzhou
pangzhenzhou approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@pangzhenzhou pangzhenzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #932 (3546434) into main (158b03e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #932      +/-   ##
============================================
- Coverage     71.49%   71.49%   -0.01%     
  Complexity     2766     2766              
============================================
  Files           970      970              
  Lines         56587    56591       +4     
  Branches       1787     1787              
============================================
  Hits          40457    40457              
- Misses        15240    15244       +4     
  Partials        890      890
Flag Coverage Δ
java 61.23% <ø> (ø)
rust 75.45% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/connector/src/kafka/source/message.rs 0.00% <0.00%> (ø)
rust/connector/src/kafka/source/reader.rs 0.00% <0.00%> (ø)
rust/connector/src/kinesis/source/message.rs 0.00% <0.00%> (ø)
rust/connector/src/kinesis/source/reader.rs 0.00% <0.00%> (ø)
rust/connector/src/pulsar/source/message.rs 0.00% <0.00%> (ø)
rust/connector/src/pulsar/source/reader.rs 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@shanicky shanicky merged commit e3b2814 into main Mar 15, 2022
@shanicky shanicky deleted the peng/new-reader-next-api branch March 15, 2022 09:32
tabVersion
tabVersion approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pangzhenzhou pushed a commit that referenced this pull request Mar 28, 2022
@shanicky
feat: use inner message (#932)
1f1db46 
Signed-off-by: Peng Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tabVersion tabVersion tabVersion approved these changes

+1 more reviewer

@pangzhenzhou pangzhenzhou pangzhenzhou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shanicky @pangzhenzhou @tabVersion