feat(binder): bind & plan DELETE
#912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #912 +/- ##
============================================
- Coverage 72.49% 72.44% -0.06%
Complexity 2766 2766
============================================
Files 936 940 +4
Lines 55274 55366 +92
Branches 1787 1787
============================================
+ Hits 40070 40108 +38
- Misses 14314 14368 +54
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Member
Author
|
First time to the frontend. 🤣 Please feel free to take a look! |
Signed-off-by: Bugen Zhao <[email protected]>
st1page
approved these changes
Mar 15, 2022
|
|
||
| let order = Order::any().clone(); | ||
| let dist = Distribution::any().clone(); | ||
| let mut out_fields = FixedBitSet::with_capacity(plan.schema().len()); |
Contributor
There was a problem hiding this comment.
maybe the delete operator's output should have no column?
Member
Author
There was a problem hiding this comment.
Also seems to return the affected rows?
https://www.postgresql.org/docs/9.6/sql-delete.html
Signed-off-by: Bugen Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
As title.
Checklist
Refer to a related PR or issue link (optional)
DELETE#898DELETEin TableV2 #16