Skip to content

feat(expr): implement degrees and radians #9108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 12, 2023
Merged

feat(expr): implement degrees and radians #9108

merged 13 commits into from
Apr 12, 2023

Conversation

@gengteng
Copy link
Contributor

@gengteng gengteng commented Apr 11, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

implement degrees and radians

resolve #8901

Related PR: #8806

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

Types of user-facing changes

  • SQL commands, functions, and operators

Release note

  • add the degrees and radians functions

lmatz
lmatz approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution

@lmatz lmatz added this pull request to the merge queue Apr 12, 2023
Merged via the queue into risingwavelabs:main with commit 6791cb1 Apr 12, 2023
@gengteng gengteng deleted the degrees_and_radians branch April 12, 2023 14:52
@CAJan93 CAJan93 mentioned this pull request Apr 17, 2023
Merged
7 tasks
@CharlieSYH CharlieSYH mentioned this pull request May 19, 2023
Closed
@CharlieSYH CharlieSYH added the 📖✓ Covered or will be covered in the user docs. label May 19, 2023
@bernscode bernscode mentioned this pull request May 31, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmatz lmatz lmatz approved these changes

Assignees

No one assigned

Labels

📖✓ Covered or will be covered in the user docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement degrees / radians

3 participants

@gengteng @lmatz @CharlieSYH