Skip to content

feat(frontend): bind & plan order by #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 15, 2022
Merged

feat(frontend): bind & plan order by #908

merged 10 commits into from
Mar 15, 2022

Conversation

@xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Mar 15, 2022 •
edited
Loading

What's changed and what's your intention?

  • Support aliases in select.
  • Allow order by output column names.
  • Cannot order by arbitrary expr yet.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#909

@github-actions github-actions bot added the type/feature Type: New feature. label Mar 15, 2022
@codecov
Copy link

codecov bot commented Mar 15, 2022 •
edited
Loading

Codecov Report

Merging #908 (0159e35) into main (98b5f10) will increase coverage by 0.01%.
The diff coverage is 95.52%.

@@             Coverage Diff              @@
##               main     #908      +/-   ##
============================================
+ Coverage     71.26%   71.28%   +0.01%     
  Complexity     2766     2766              
============================================
  Files           965      964       -1     
  Lines         56435    56477      +42     
  Branches       1787     1787              
============================================
+ Hits          40216    40257      +41     
- Misses        15329    15330       +1     
  Partials        890      890
Flag Coverage Δ
java 61.23% <ø> (ø)
rust 75.17% <95.52%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/frontend/src/binder/expr/column.rs 76.92% <ø> (-5.43%) ⬇️
rust/frontend/src/binder/mod.rs 100.00% <ø> (ø)
...ust/frontend/src/optimizer/plan_node/batch_sort.rs 0.00% <0.00%> (ø)
rust/frontend/src/binder/bind_context.rs 88.00% <100.00%> (ø)
rust/frontend/src/binder/query.rs 100.00% <100.00%> (ø)
rust/frontend/src/binder/select.rs 98.07% <100.00%> (+4.32%) ⬆️
rust/frontend/src/binder/table_ref.rs 76.00% <100.00%> (+0.32%) ⬆️
rust/frontend/src/planner/query.rs 100.00% <100.00%> (ø)
rust/frontend/src/planner/select.rs 62.50% <100.00%> (-2.21%) ⬇️
rust/meta/src/hummock/compaction.rs 81.56% <0.00%> (+0.55%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xiangjinwu xiangjinwu marked this pull request as ready for review March 15, 2022 03:17
likg227
likg227 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@likg227 likg227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiangjinwu xiangjinwu enabled auto-merge (squash) March 15, 2022 05:35
@xiangjinwu xiangjinwu merged commit f88e299 into main Mar 15, 2022
@xiangjinwu xiangjinwu deleted the rust-frontend-order-by branch March 15, 2022 05:50
pangzhenzhou pushed a commit that referenced this pull request Mar 28, 2022
@xiangjinwu
feat(frontend): bind & plan order by (#908)
99d4cd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xxchan xxchan Awaiting requested review from xxchan

@neverchanje neverchanje Awaiting requested review from neverchanje

1 more reviewer

@likg227 likg227 likg227 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xiangjinwu @likg227