Skip to content

feat: support psql tab-completion for relation names #8839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2023
Merged

feat: support psql tab-completion for relation names #8839

merged 4 commits into from
Mar 28, 2023

Conversation

@xxchan
Copy link
Collaborator

@xxchan xxchan commented Mar 28, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

by:

  • add function quote_ident
  • hack max one row check for pg_namespace

image

fix #8837

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

add function quote_ident(See code comment

@github-actions github-actions bot added type/feature Type: New feature. user-facing-changes Contains changes that are visible to users labels Mar 28, 2023
@xxchan
feat: support psql tab-completion for relation names
5f30eea 
by:
- add function `quote_ident`
- hack max one row check for `pg_namespace`
@xxchan xxchan force-pushed the xxchan/independent-alpaca branch from 7e1166b to 5f30eea Compare March 28, 2023 15:30
wangrunji0408
wangrunji0408 reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function part LGTM!

chenzl25
chenzl25 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM!

@codecov
Copy link

codecov bot commented Mar 28, 2023 •
edited
Loading

Codecov Report

Merging #8839 (1d37e1f) into main (9df0e15) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #8839      +/-   ##
==========================================
- Coverage   70.81%   70.81%   -0.01%     
==========================================
  Files        1171     1171              
  Lines      194474   194496      +22     
==========================================
+ Hits       137719   137727       +8     
- Misses      56755    56769      +14
Flag Coverage Δ
rust 70.81% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/frontend/src/optimizer/plan_node/logical_scan.rs 95.99% <ø> (+0.49%) ⬆️
...nd/src/optimizer/plan_node/stream_temporal_join.rs 65.68% <0.00%> (ø)
src/expr/src/vector_op/string.rs 8.90% <6.25%> (-0.33%) ⬇️
.../src/optimizer/plan_visitor/max_one_row_visitor.rs 66.66% <50.00%> (-2.66%) ⬇️
src/frontend/src/binder/expr/function.rs 89.13% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xxchan xxchan enabled auto-merge March 28, 2023 16:57
@xxchan xxchan disabled auto-merge March 28, 2023 17:00
@xxchan xxchan enabled auto-merge March 28, 2023 17:00
@xxchan xxchan added this pull request to the merge queue Mar 28, 2023
Merged via the queue into main with commit 81b306b Mar 28, 2023
@xxchan xxchan deleted the xxchan/independent-alpaca branch March 28, 2023 17:48
@hengm3467 hengm3467 mentioned this pull request Mar 30, 2023
Closed
@CharlieSYH CharlieSYH added the 📖✓ Covered or will be covered in the user docs. label Apr 18, 2023
@hzxa21 hzxa21 mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenzl25 chenzl25 chenzl25 approved these changes

@st1page st1page Awaiting requested review from st1page

+1 more reviewer

@wangrunji0408 wangrunji0408 wangrunji0408 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature. user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support psql tab-completion for relations

5 participants

@xxchan @chenzl25 @wangrunji0408 @CharlieSYH