feat(batch): introduce delete executor in compute node #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #883 +/- ##
============================================
+ Coverage 72.30% 72.32% +0.02%
Complexity 2766 2766
============================================
Files 934 935 +1
Lines 54867 54992 +125
Branches 1787 1787
============================================
+ Hits 39670 39772 +102
- Misses 14307 14330 +23
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
lmatz
reviewed
Mar 14, 2022
| } | ||
|
|
||
| async fn next(&mut self) -> Result<Option<DataChunk>> { | ||
| if self.executed { |
Contributor
There was a problem hiding this comment.
Not specific to this PR, just try to confirm whether it is the standard in our system now that next on an already finished executor should be a no-op instead of err?
Member
Author
There was a problem hiding this comment.
+1. Also curious about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
This PR introduces delete executor in
batchcrate.Checklist
Refer to a related PR or issue link (optional)
A step of #16.