Skip to content

feat(planner): plan inner join #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2022
Merged

feat(planner): plan inner join #876

merged 1 commit into from
Mar 14, 2022

Conversation

@TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented Mar 14, 2022

Signed-off-by: TennyZhuang [email protected]

What's changed and what's your intention?

Convert Inner join to Logical Plan

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@TennyZhuang TennyZhuang requested a review from st1page March 14, 2022 04:03
@github-actions github-actions bot added the type/feature Type: New feature. label Mar 14, 2022
st1page
st1page approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TennyZhuang TennyZhuang enabled auto-merge (squash) March 14, 2022 04:05
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #876 (65d3ae6) into main (18cedb3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #876      +/-   ##
============================================
+ Coverage     72.26%   72.28%   +0.02%     
  Complexity     2766     2766              
============================================
  Files           931      931              
  Lines         54744    54752       +8     
  Branches       1787     1787              
============================================
+ Hits          39562    39580      +18     
+ Misses        14292    14282      -10     
  Partials        890      890
Flag Coverage Δ
java 61.22% <ø> (ø)
rust 76.76% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/frontend/src/binder/mod.rs 100.00% <ø> (ø)
...t/frontend/src/optimizer/plan_node/logical_scan.rs 88.00% <ø> (ø)
...t/frontend/src/optimizer/plan_node/logical_join.rs 77.41% <100.00%> (+3.10%) ⬆️
rust/frontend/src/planner/table_ref.rs 100.00% <100.00%> (ø)
rust/common/src/types/ordered_float.rs 25.82% <0.00%> (+0.33%) ⬆️
rust/meta/src/cluster/mod.rs 75.26% <0.00%> (+0.35%) ⬆️
rust/meta/src/hummock/compaction.rs 82.24% <0.00%> (+0.59%) ⬆️
rust/meta/src/model/cluster.rs 86.66% <0.00%> (+13.33%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang TennyZhuang merged commit c5f78e8 into main Mar 14, 2022
@TennyZhuang TennyZhuang deleted the feat/plan-inner-join branch March 14, 2022 04:18
@xiangjinwu xiangjinwu linked an issue Mar 15, 2022 that may be closed by this pull request
Bind Join #919
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@st1page st1page st1page approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bind Join

3 participants

@TennyZhuang @st1page