-
Notifications
You must be signed in to change notification settings - Fork 706
feat: add catalog service v2 proto definition #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BugenZhao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
neverchanje
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Codecov Report
@@ Coverage Diff @@
## main #867 +/- ##
============================================
- Coverage 72.18% 72.18% -0.01%
Complexity 2766 2766
============================================
Files 930 931 +1
Lines 54398 54399 +1
Branches 1787 1787
============================================
Hits 39267 39267
- Misses 14241 14242 +1
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
BugenZhao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @neverchanje
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
int32touint32ViewtoVirtualTableChecklist
Refer to a related PR or issue link (optional)
relate #866