Skip to content

Conversation

@yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Mar 11, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • change catalog id type from int32 to uint32
  • rename View to VirtualTable
  • introduce catalog rpc service v2

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

relate #866

@yezizp2012 yezizp2012 requested review from BugenZhao and st1page March 11, 2022 08:32
@github-actions github-actions bot added the type/feature Type: New feature. label Mar 11, 2022
@yezizp2012 yezizp2012 requested a review from neverchanje March 11, 2022 08:37
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #867 (67ca7e9) into main (53c479c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 67ca7e9 differs from pull request most recent head 37d5303. Consider uploading reports for the commit 37d5303 to get more accurate results

@@             Coverage Diff              @@
##               main     #867      +/-   ##
============================================
- Coverage     72.18%   72.18%   -0.01%     
  Complexity     2766     2766              
============================================
  Files           930      931       +1     
  Lines         54398    54399       +1     
  Branches       1787     1787              
============================================
  Hits          39267    39267              
- Misses        14241    14242       +1     
  Partials        890      890              
Flag Coverage Δ
java 61.22% <ø> (ø)
rust 76.65% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/manager/catalog_v2.rs 0.00% <ø> (ø)
rust/meta/src/model/catalog_v2.rs 0.00% <ø> (ø)
rust/meta/src/rpc/service/catalog_service_v2.rs 0.00% <0.00%> (ø)
rust/meta/src/rpc/service/mod.rs 0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012 yezizp2012 enabled auto-merge (squash) March 11, 2022 08:54
@yezizp2012 yezizp2012 merged commit 62e5d9f into main Mar 11, 2022
@yezizp2012 yezizp2012 deleted the feat/add-catalog-srv-v2 branch March 11, 2022 09:11
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants