Skip to content

feat: add notification for catalog-v2 #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2022
Merged

feat: add notification for catalog-v2 #850

merged 1 commit into from
Mar 11, 2022

Conversation

@yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Mar 11, 2022 •
edited
Loading

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Add notification for catalog-v2.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@yezizp2012 yezizp2012 requested review from HuaHuaY and st1page March 11, 2022 05:56
@yezizp2012 yezizp2012 enabled auto-merge (squash) March 11, 2022 05:56
@github-actions github-actions bot added the type/feature Type: New feature. label Mar 11, 2022
HuaHuaY
HuaHuaY approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@HuaHuaY HuaHuaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

st1page
st1page approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #850 (cc5974f) into main (6cbaf20) will decrease coverage by 0.05%.
The diff coverage is 2.32%.

@@             Coverage Diff              @@
##               main     #850      +/-   ##
============================================
- Coverage     72.02%   71.96%   -0.06%     
  Complexity     2766     2766              
============================================
  Files           927      927              
  Lines         54086    54127      +41     
  Branches       1787     1787              
============================================
  Hits          38953    38953              
- Misses        14243    14284      +41     
  Partials        890      890
Flag Coverage Δ
java 61.22% <ø> (ø)
rust 76.38% <2.32%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/frontend/src/observer/observer_manager.rs 85.71% <0.00%> (-0.96%) ⬇️
rust/meta/src/manager/catalog_v2.rs 0.00% <0.00%> (ø)
rust/meta/src/cluster/mod.rs 77.88% <50.00%> (ø)
rust/batch/src/executor/row_seq_scan.rs 45.94% <0.00%> (ø)
...m/risingwave/planner/rel/physical/RwBatchScan.java 100.00% <0.00%> (ø)
rust/storage/src/table/row_table.rs
rust/storage/src/table/cell_based_table.rs 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012 yezizp2012 merged commit 77d143d into main Mar 11, 2022
@yezizp2012 yezizp2012 deleted the feat/catalog-v2-notify branch March 11, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@st1page st1page st1page approved these changes

@HuaHuaY HuaHuaY HuaHuaY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yezizp2012 @st1page @HuaHuaY