Skip to content

fix(ci): add build depends for sqlsmith #8312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2023
Merged

fix(ci): add build depends for sqlsmith #8312

merged 2 commits into from
Mar 2, 2023

Conversation

@kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Mar 2, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add developer docs as well.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Mar 2, 2023
@kwannoel kwannoel requested a review from lmatz March 2, 2023 14:45
@kwannoel kwannoel mentioned this pull request Mar 2, 2023
Merged
6 tasks
@codecov
Copy link

codecov bot commented Mar 2, 2023 •
edited
Loading

Codecov Report

Merging #8312 (b92433b) into main (1ad23ba) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8312      +/-   ##
==========================================
- Coverage   71.65%   71.64%   -0.01%     
==========================================
  Files        1131     1131              
  Lines      184150   184150              
==========================================
- Hits       131948   131931      -17     
- Misses      52202    52219      +17
Flag Coverage Δ
rust 71.64% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/group_top_n.rs 68.23% <0.00%> (-6.48%) ⬇️
...torage/src/hummock/local_version/pinned_version.rs 88.75% <0.00%> (-0.63%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 65.46% <0.00%> (-0.52%) ⬇️
src/object_store/src/object/mem.rs 86.87% <0.00%> (-0.39%) ⬇️
src/object_store/src/object/mod.rs 47.87% <0.00%> (-0.21%) ⬇️
src/storage/src/hummock/sstable_store.rs 64.77% <0.00%> (-0.16%) ⬇️
src/common/src/cache.rs 97.15% <0.00%> (-0.11%) ⬇️
src/stream/src/executor/aggregation/minput.rs 96.25% <0.00%> (-0.11%) ⬇️
src/common/src/types/ordered_float.rs 31.06% <0.00%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2023

Hey @kwannoel, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with git commit --allow-empty -m "rerun" && git push.

@kwannoel kwannoel added this pull request to the merge queue Mar 2, 2023
Merged via the queue into main with commit 94b2d54 Mar 2, 2023
@kwannoel kwannoel deleted the kwannoel/sqlsmith-docs branch March 2, 2023 15:39
WillyKidd pushed a commit that referenced this pull request Mar 3, 2023
@kwannoel @WillyKidd
fix(ci): add build depends for sqlsmith (#8312)
ad6287c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmatz lmatz lmatz approved these changes

Assignees

No one assigned

Labels

type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kwannoel @lmatz