fix(riselab): do not enable all components on --default
#83
+26
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
approved these changes
Jan 30, 2022
Contributor
skyzh
left a comment
There was a problem hiding this comment.
Also consider switching to a new env variable for release mode, so that users mistakenly using release mode can use debug by default.
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
============================================
- Coverage 74.48% 74.47% -0.02%
Complexity 2645 2645
============================================
Files 824 828 +4
Lines 47332 47351 +19
Branches 1560 1560
============================================
+ Hits 35257 35265 +8
- Misses 11277 11288 +11
Partials 798 798
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
TennyZhuang
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
RiseLAB configuration generator should not enable all components on
--default.Checklist
Refer to a related PR or issue link (optional)
Close #82.