Skip to content

chore(common): fix remaining GAT workarounds #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2022
Merged

chore(common): fix remaining GAT workarounds #825

merged 1 commit into from
Mar 10, 2022

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 10, 2022 •
edited
Loading

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

Remove workarounds for GATs

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

hold until #824

@skyzh skyzh requested review from fuyufjh and lmatz March 10, 2022 09:00
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #825 (d6e0321) into main (28e1e21) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #825   +/-   ##
=========================================
  Coverage     72.22%   72.23%           
  Complexity     2766     2766           
=========================================
  Files           923      923           
  Lines         53652    53652           
  Branches       1787     1787           
=========================================
+ Hits          38751    38753    +2     
+ Misses        14011    14009    -2     
  Partials        890      890
Flag Coverage Δ
java 61.22% <ø> (ø)
rust 76.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/common/src/vector_op/agg/functions.rs 77.77% <ø> (ø)
rust/common/src/vector_op/agg/general_agg.rs 97.16% <ø> (ø)
...t/common/src/vector_op/agg/general_distinct_agg.rs 75.49% <ø> (ø)
rust/meta/src/hummock/compaction.rs 82.24% <0.00%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28e1e21...d6e0321. Read the comment docs.

@lmatz lmatz merged commit 8ce69a3 into main Mar 10, 2022
@lmatz lmatz deleted the skyzh/agg-gat branch March 10, 2022 09:15
@lmatz lmatz mentioned this pull request Mar 11, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmatz lmatz lmatz approved these changes

@fuyufjh fuyufjh fuyufjh approved these changes

Assignees

No one assigned

Labels

type/chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skyzh @lmatz @fuyufjh