Skip to content

feat(streaming): implement lookup row from storage #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2022
Merged

feat(streaming): implement lookup row from storage #822

merged 1 commit into from
Mar 10, 2022

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 10, 2022 •
edited
Loading

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title. Tests are not added yet.

We will need a cache in the future, so as to reduce requests to the storage layer.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

ref #719

@skyzh skyzh requested review from fuyufjh and yuhao-su March 10, 2022 07:42
@github-actions github-actions bot added the type/feature Type: New feature. label Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #822 (501e605) into main (d573733) will decrease coverage by 0.12%.
The diff coverage is 24.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #822      +/-   ##
============================================
- Coverage     72.33%   72.20%   -0.13%     
  Complexity     2762     2762              
============================================
  Files           921      922       +1     
  Lines         53370    53461      +91     
  Branches       1787     1787              
============================================
  Hits          38603    38603              
- Misses        13873    13964      +91     
  Partials        894      894
Flag Coverage Δ
java 61.17% <ø> (ø)
rust 76.82% <24.28%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/common/src/util/ordered/serde.rs 79.89% <0.00%> (-2.70%) ⬇️
rust/storage/src/cell_based_row_deserializer.rs 100.00% <ø> (ø)
rust/storage/src/keyspace.rs 77.27% <0.00%> (-2.42%) ⬇️
rust/stream/src/executor/hash_join.rs 81.10% <ø> (-1.24%) ⬇️
rust/stream/src/executor/lookup/impl_.rs 0.00% <0.00%> (ø)
rust/stream/src/executor/lookup/sides.rs 0.00% <0.00%> (ø)
rust/stream/src/task/stream_manager.rs 55.14% <0.00%> (ø)
rust/stream/src/common/builder.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d573733...501e605. Read the comment docs.

@skyzh skyzh requested a review from BugenZhao March 10, 2022 08:00
@skyzh skyzh enabled auto-merge (squash) March 10, 2022 08:00
@skyzh skyzh merged commit 28e1e21 into main Mar 10, 2022
@skyzh skyzh deleted the skyzh/impl-lookup-storage branch March 10, 2022 08:24
@skyzh skyzh mentioned this pull request Apr 11, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuhao-su yuhao-su yuhao-su approved these changes

@fuyufjh fuyufjh Awaiting requested review from fuyufjh

@BugenZhao BugenZhao Awaiting requested review from BugenZhao

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skyzh @yuhao-su