Skip to content

feat(frontend): derive primary key for anti and semi join #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2022
Merged

feat(frontend): derive primary key for anti and semi join #816

merged 1 commit into from
Mar 10, 2022

Conversation

@lmatz
Copy link
Contributor

@lmatz lmatz commented Mar 10, 2022 •
edited
Loading

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:
Derive primary key for anti and semi join.
Both join outputs only records from its left child.
Therefore the output primary key indices simply inherit from the primary key indices of its left child.

Fixed some comments in primary key derivation.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

@github-actions github-actions bot added the type/feature Type: New feature. label Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #816 (54be474) into main (4e9e18b) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #816      +/-   ##
============================================
+ Coverage     72.42%   72.43%   +0.01%     
- Complexity     2762     2766       +4     
============================================
  Files           918      918              
  Lines         53289    53306      +17     
  Branches       1787     1787              
============================================
+ Hits          38594    38613      +19     
- Misses        13801    13803       +2     
+ Partials        894      890       -4
Flag Coverage Δ
java 61.22% <66.66%> (+0.04%) ⬆️
rust 77.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ner/rel/streaming/PrimaryKeyDerivationVisitor.java 91.91% <66.66%> (+0.04%) ⬆️
rust/meta/src/manager/epoch.rs 78.78% <0.00%> (-3.04%) ⬇️
rust/meta/src/model/catalog.rs 91.22% <0.00%> (-1.63%) ⬇️
rust/frontend/src/catalog/catalog_service.rs 86.22% <0.00%> (-0.60%) ⬇️
rust/meta/src/manager/catalog.rs 75.54% <0.00%> (-0.09%) ⬇️
rust/common/src/catalog/mod.rs 66.66% <0.00%> (ø)
rust/meta/src/rpc/service/catalog_service.rs 100.00% <0.00%> (ø)
rust/rpc_client/src/meta_client.rs 59.30% <0.00%> (+0.23%) ⬆️
rust/common/src/types/ordered_float.rs 25.82% <0.00%> (+0.33%) ⬆️
...r/rules/logical/subquery/SubQueryDecorrelator.java 38.94% <0.00%> (+0.52%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9e18b...54be474. Read the comment docs.

@lmatz lmatz requested a review from fuyufjh March 10, 2022 06:23
fuyufjh
fuyufjh approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmatz lmatz merged commit de028de into main Mar 10, 2022
@lmatz lmatz deleted the lz/pk branch March 10, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuyufjh fuyufjh fuyufjh approved these changes

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lmatz @fuyufjh