Skip to content

feat(planner): add batch scan plan node definition #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 8, 2022
Merged

feat(planner): add batch scan plan node definition #81

merged 3 commits into from
Feb 8, 2022

Conversation

@BowenXiao1999
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 commented Jan 30, 2022 •
edited
Loading

What's changed and what's your intention?

This is a pre-req issue of batch plan scheduler. I use some methods in unittest so it can not be todo!() any more.

  • def of Logical Scan
  • change id from u32 -> u64

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@BowenXiao1999 BowenXiao1999 marked this pull request as draft January 30, 2022 07:37
@github-actions github-actions bot added the type/feature Type: New feature. label Jan 30, 2022
@BowenXiao1999 BowenXiao1999 requested a review from st1page February 7, 2022 09:22
@codecov
Copy link

codecov bot commented Feb 7, 2022 •
edited
Loading

Codecov Report

Merging #81 (4719fc8) into main (501998c) will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #81      +/-   ##
============================================
- Coverage     74.51%   74.45%   -0.06%     
- Complexity     2645     2654       +9     
============================================
  Files           830      833       +3     
  Lines         47640    47828     +188     
  Branches       1560     1562       +2     
============================================
+ Hits          35497    35612     +115     
- Misses        11345    11417      +72     
- Partials        798      799       +1
Flag Coverage Δ
java 62.08% <ø> (+0.17%) ⬆️
rust 79.80% <33.33%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/frontend/src/catalog/mod.rs 100.00% <ø> (ø)
...frontend/src/optimizer/plan_node/batch_seq_scan.rs 0.00% <0.00%> (ø)
...t/frontend/src/optimizer/plan_node/logical_scan.rs 0.00% <0.00%> (ø)
rust/frontend/src/catalog/table_catalog.rs 79.31% <66.66%> (+2.64%) ⬆️
rust/frontend/src/catalog/database_catalog.rs 94.11% <100.00%> (ø)
rust/meta/src/stream/meta.rs 58.57% <0.00%> (-38.54%) ⬇️
rust/meta/src/manager/config.rs 50.68% <0.00%> (-11.08%) ⬇️
rust/meta/src/barrier/mod.rs 65.90% <0.00%> (-4.33%) ⬇️
rust/meta/src/barrier/command.rs 44.00% <0.00%> (-3.92%) ⬇️
rust/meta/src/stream/stream_manager.rs 89.49% <0.00%> (-0.72%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 501998c...4719fc8. Read the comment docs.

st1page
st1page reviewed Feb 8, 2022
View reviewed changes
@BowenXiao1999 BowenXiao1999 marked this pull request as ready for review February 8, 2022 07:18
fuyufjh
fuyufjh approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

st1page
st1page approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BowenXiao1999 BowenXiao1999 enabled auto-merge (squash) February 8, 2022 07:27
@BowenXiao1999 BowenXiao1999 merged commit d21d536 into main Feb 8, 2022
@BowenXiao1999 BowenXiao1999 deleted the bw_add_scan_plan_node branch February 8, 2022 07:29
@BowenXiao1999 BowenXiao1999 mentioned this pull request Feb 21, 2022
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuyufjh fuyufjh fuyufjh approved these changes

+1 more reviewer

@st1page st1page st1page approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BowenXiao1999 @fuyufjh @st1page