Skip to content

Conversation

@lmatz
Copy link
Contributor

@lmatz lmatz commented Mar 9, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:
Let the stream planner uses the new subquery rewrite program introduced by @liurenjie1024.

Since some plan still requires the old subquery rewrite, this PR adds a config option similar to the config option for the batch planner, which controls of using which subquery rewriter.

This blocks several streaming tpch query.

@github-actions github-actions bot added the type/feature Type: New feature. label Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #809 (d02b887) into main (f3ea652) will increase coverage by 0.00%.
The diff coverage is 92.10%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #809   +/-   ##
=========================================
  Coverage     72.41%   72.41%           
- Complexity     2759     2762    +3     
=========================================
  Files           917      918    +1     
  Lines         53237    53265   +28     
  Branches       1784     1787    +3     
=========================================
+ Hits          38549    38573   +24     
- Misses        13796    13798    +2     
- Partials        892      894    +2     
Flag Coverage Δ
java 61.17% <92.10%> (+0.04%) ⬆️
rust 77.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gwave/planner/planner/streaming/StreamPlanner.java 90.37% <76.92%> (-1.63%) ⬇️
...wave/common/config/BatchPlannerConfigurations.java 100.00% <100.00%> (ø)
...va/com/risingwave/common/config/Configuration.java 59.67% <100.00%> (+3.53%) ⬆️
...ave/common/config/StreamPlannerConfigurations.java 100.00% <100.00%> (ø)
...risingwave/planner/planner/batch/BatchPlanner.java 92.53% <100.00%> (+0.34%) ⬆️
.../java/com/risingwave/planner/sql/SqlConverter.java 92.15% <100.00%> (+0.49%) ⬆️
rust/connector/src/filesystem/file_common.rs 85.71% <0.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ea652...d02b887. Read the comment docs.

@fuyufjh fuyufjh requested a review from liurenjie1024 March 9, 2022 16:36
@lmatz lmatz requested review from fuyufjh and removed request for liurenjie1024 March 10, 2022 01:00
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmatz lmatz merged commit 4e9e18b into main Mar 10, 2022
@lmatz lmatz deleted the lz/subquery branch March 10, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants