Skip to content

feat(parser): ALTER SYSTEM #7913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 14, 2023
Merged

feat(parser): ALTER SYSTEM #7913

merged 5 commits into from
Feb 14, 2023

Conversation

@Gun9niR
Copy link
Contributor

@Gun9niR Gun9niR commented Feb 14, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The syntax is

ALTER SYSTEM SET configuration_parameter { TO | = } { value | 'value' | DEFAULT }

Checklist

  • I have added necessary unit tests and integration tests
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

Use ALTER SYSTEM SET configuration_parameter { TO | = } { value | 'value' | DEFAULT } to modify system parameters.

@github-actions github-actions bot added the type/feature Type: New feature. label Feb 14, 2023
TennyZhuang
TennyZhuang approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gun9niR Gun9niR added mergify/can-merge A-frontend Area: Protocol, parsing, binder. user-facing-changes Contains changes that are visible to users labels Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023 •
edited
Loading

Codecov Report

Merging #7913 (f7f6192) into main (5b64db7) will increase coverage by 0.00%.
The diff coverage is 93.10%.

@@           Coverage Diff           @@
##             main    #7913   +/-   ##
=======================================
  Coverage   71.71%   71.71%           
=======================================
  Files        1113     1113           
  Lines      177671   177694   +23     
=======================================
+ Hits       127417   127439   +22     
- Misses      50254    50255    +1
Flag Coverage Δ
rust 71.71% <93.10%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/mod.rs 61.11% <0.00%> (-0.25%) ⬇️
src/sqlparser/src/parser.rs 91.58% <95.23%> (+<0.01%) ⬆️
src/sqlparser/src/ast/mod.rs 89.04% <100.00%> (+0.06%) ⬆️
src/source/src/row_id.rs 90.90% <0.00%> (-1.14%) ⬇️
src/stream/src/executor/aggregation/minput.rs 96.34% <0.00%> (+0.10%) ⬆️
src/common/src/types/ordered_float.rs 31.06% <0.00%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 1d95ad0 into main Feb 14, 2023
@mergify mergify bot deleted the zhidong/parser-alter-system branch February 14, 2023 08:57
@Gun9niR Gun9niR mentioned this pull request Feb 15, 2023
Closed
9 tasks
@hengm3467 hengm3467 mentioned this pull request Feb 21, 2023
Closed
@hengm3467 hengm3467 mentioned this pull request Mar 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TennyZhuang TennyZhuang TennyZhuang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-frontend Area: Protocol, parsing, binder. type/feature Type: New feature. user-facing-changes Contains changes that are visible to users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gun9niR @TennyZhuang