feat(expr): support pow function #7789
Merged
+147
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7789 +/- ##
==========================================
- Coverage 71.68% 71.67% -0.01%
==========================================
Files 1100 1100
Lines 175690 175707 +17
==========================================
- Hits 125937 125936 -1
- Misses 49753 49771 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TennyZhuang
reviewed
Feb 8, 2023
| } | ||
|
|
||
| #[inline(always)] | ||
| pub fn general_pow<T1, T2, T3>(l: T1, r: T2) -> Result<T3> |
Contributor
There was a problem hiding this comment.
If we cast them in frontend, I guess we can only support a concrete implementation (f64,f64)->f64 instead of a general one.
Collaborator
There was a problem hiding this comment.
At least the Decimal version needs to be implemented besides the f64 version.
TennyZhuang
approved these changes
Feb 8, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As per the title.
Right now, both x and y are casted into Float64 when pow(x, y).
By PG's standard, we also need to support Decimal but Decimal has no built-in pow and we may also change the underlying crate for Decimal. So we leave it aside for now.
Urgently requested by user.
#7725
Checklist
./risedev check(or alias,./risedev c)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
powis a mathematical function, see https://www.postgresql.org/docs/7.4/functions-math.htmlBut this PR only implements for dp(double precision) as function parameters. Decimal has not been implemented yet.
Refer to a related PR or issue link (optional)
#7725