Skip to content

feat(frontend): support show internal tables #7348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 12, 2023
Merged

feat(frontend): support show internal tables #7348

merged 5 commits into from
Jan 12, 2023

Conversation

@chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Jan 12, 2023 •
edited
Loading

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

This section will be used as the commit message. Please do not leave this empty!

  • Support show internal tables.

Example:

dev=> show internal tables;
                   Name
------------------------------------------
 __internal_v_20_hashjoinright_1019
 __internal_v_20_hashjoindegreeleft_1018
 __internal_v_18_grouptopnnode_1011
 __internal_v_20_hashjoindegreeright_1020
 __internal_v_17_topnnode_1010
 __internal_v_19_hashjoindegreeleft_1014
 __internal_v_20_hashjoinleft_1017
 __internal_v_18_hashaggresult_1012
 __internal_v_19_hashjoinright_1015
 __internal_v_19_hashjoindegreeright_1016
 __internal_v_19_hashjoinleft_1013
(11 rows)

dev=> select * from __internal_v_19_hashjoinleft_1013 limit 5;
 orders.o_orderkey | orders.o_orderdate | orders.o_shippriority | customer.c_custkey | orders.o_custkey
-------------------+--------------------+-----------------------+--------------------+------------------
                69 | 1994-06-04         |                     0 |                 85 |               85
               256 | 1993-10-19         |                     0 |                125 |              125
              1154 | 1992-02-15         |                     0 |                 37 |               37
              1792 | 1993-11-09         |                     0 |                 49 |               49
              1894 | 1992-03-30         |                     0 |                 76 |               76
(5 rows)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • SQL commands, functions, and operators

Release note

  • Support show internal tables statement. Developers will be able to explore the state implementation of RisingWave in depth with this statement.

Refer to a related PR or issue link (optional)

#7304

@github-actions github-actions bot added the type/feature Type: New feature. label Jan 12, 2023
@chenzl25 chenzl25 added user-facing-changes Contains changes that are visible to users and removed type/feature Type: New feature. labels Jan 12, 2023
@github-actions github-actions bot added the type/feature Type: New feature. label Jan 12, 2023
@chenzl25 chenzl25 requested a review from fuyufjh January 12, 2023 06:59
fuyufjh
fuyufjh approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jon-chuang
Copy link
Contributor

jon-chuang commented Jan 12, 2023 •
edited
Loading

Just curious, querying from this will query the StateTable corresponding to the internal table via a MaterializeExecutor is this correct?

jon-chuang
jon-chuang reviewed Jan 12, 2023
View reviewed changes
@fuyufjh
Copy link
Collaborator

fuyufjh commented Jan 12, 2023 •
edited
Loading

Just curious, querying from this will query the StateTable corresponding to the internal table via a MaterializeExecutor is this correct?

No, a batch operator will be constructed to query from storage layer directly. To be more precise, read from the shared buffer of the compute node(s)

@codecov
Copy link

codecov bot commented Jan 12, 2023 •
edited
Loading

Codecov Report

Merging #7348 (195d036) into main (eca9541) will decrease coverage by 0.00%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main    #7348      +/-   ##
==========================================
- Coverage   73.00%   73.00%   -0.01%     
==========================================
  Files        1069     1069              
  Lines      171099   171117      +18     
==========================================
+ Hits       124917   124921       +4     
- Misses      46182    46196      +14
Flag Coverage Δ
rust 73.00% <22.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/catalog/schema_catalog.rs 64.84% <0.00%> (-1.56%) ⬇️
src/frontend/src/catalog/table_catalog.rs 92.98% <0.00%> (-0.83%) ⬇️
src/frontend/src/handler/show.rs 62.72% <0.00%> (-1.46%) ⬇️
src/sqlparser/src/keywords.rs 100.00% <ø> (ø)
src/sqlparser/src/ast/mod.rs 88.62% <100.00%> (+0.02%) ⬆️
src/sqlparser/src/parser.rs 92.08% <100.00%> (+<0.01%) ⬆️
src/object_store/src/object/mem.rs 87.12% <0.00%> (-0.38%) ⬇️
src/object_store/src/object/mod.rs 51.08% <0.00%> (-0.22%) ⬇️
src/storage/src/hummock/sstable_store.rs 64.68% <0.00%> (-0.16%) ⬇️
src/common/src/types/ordered_float.rs 31.25% <0.00%> (+0.19%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit d3244c1 into main Jan 12, 2023
@mergify mergify bot deleted the dylan/support_show_internal_tables branch January 12, 2023 10:07
@hengm3467 hengm3467 mentioned this pull request Jan 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuyufjh fuyufjh fuyufjh approved these changes

@st1page st1page Awaiting requested review from st1page

@neverchanje neverchanje Awaiting requested review from neverchanje

+1 more reviewer

@jon-chuang jon-chuang jon-chuang left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature. user-facing-changes Contains changes that are visible to users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenzl25 @jon-chuang @fuyufjh