Skip to content

feat(expr): support to_timestamp(text,text) #7060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 26, 2022
Merged

feat(expr): support to_timestamp(text,text) #7060

merged 8 commits into from
Dec 26, 2022

Conversation

@TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented Dec 26, 2022

Signed-off-by: TennyZhuang [email protected]

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

support to_timestamp(text,text)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • SQL commands, functions, and operators

Release note

  • support to_timestamp(text,text)

Refer to a related PR or issue link (optional)

#6894

@TennyZhuang TennyZhuang added the user-facing-changes Contains changes that are visible to users label Dec 26, 2022
@github-actions github-actions bot added the type/feature Type: New feature. label Dec 26, 2022
@TennyZhuang
gen dashboard
483fdf2 
Signed-off-by: TennyZhuang <[email protected]>
@TennyZhuang
fix clippy
0a45fb7 
Signed-off-by: TennyZhuang <[email protected]>
@lmatz
Copy link
Contributor

lmatz commented Dec 26, 2022

There are some test cases at https://github.com/risingwavelabs/risingwave/blob/main/src/tests/regress/data/sql/horology.sql#L354 that can be used to validate if they are helpful

@TennyZhuang
Copy link
Contributor Author

TennyZhuang commented Dec 26, 2022

There are some test cases at https://github.com/risingwavelabs/risingwave/blob/main/src/tests/regress/data/sql/horology.sql#L354 that can be used to validate if they are helpful

I'm sure only few of them can be supported, we can make them complete later.

@TennyZhuang
Copy link
Contributor Author

TennyZhuang commented Dec 26, 2022

There are too many differences between pg and chrono :)

@codecov
Copy link

codecov bot commented Dec 26, 2022 •
edited
Loading

Codecov Report

Merging #7060 (a6e82dd) into main (bcbe772) will decrease coverage by 0.03%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #7060      +/-   ##
==========================================
- Coverage   73.31%   73.28%   -0.04%     
==========================================
  Files        1045     1047       +2     
  Lines      167659   167770     +111     
==========================================
+ Hits       122926   122945      +19     
- Misses      44733    44825      +92
Flag Coverage Δ
rust 73.28% <14.28%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/error.rs 21.05% <0.00%> (-3.95%) ⬇️
src/expr/src/expr/build_expr_from_prost.rs 49.83% <0.00%> (-3.29%) ⬇️
src/expr/src/expr/expr_binary_nonnull.rs 56.34% <0.00%> (-1.85%) ⬇️
src/expr/src/expr/expr_to_timestamp_const_tmpl.rs 0.00% <0.00%> (ø)
src/expr/src/expr/mod.rs 46.93% <0.00%> (-0.98%) ⬇️
src/expr/src/vector_op/to_char.rs 0.00% <0.00%> (ø)
src/expr/src/vector_op/to_timestamp.rs 0.00% <0.00%> (ø)
src/frontend/src/binder/expr/function.rs 81.28% <50.00%> (-0.21%) ⬇️
src/expr/src/vector_op/cast.rs 89.95% <68.00%> (+0.26%) ⬆️
src/expr/src/sig/func.rs 93.60% <100.00%> (+0.02%) ⬆️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

wangrunji0408
wangrunji0408 reviewed Dec 26, 2022
View reviewed changes
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for other parts except to_timestamp_const_tmpl function. 🤯

BowenXiao1999
BowenXiao1999 approved these changes Dec 26, 2022
View reviewed changes
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@TennyZhuang
support Month/Mon
575e2d2 
Signed-off-by: TennyZhuang <[email protected]>
@TennyZhuang
add comments
b6b39d7 
Signed-off-by: TennyZhuang <[email protected]>
@mergify mergify bot merged commit 2df948c into main Dec 26, 2022
@mergify mergify bot deleted the feat/to-timestamp branch December 26, 2022 14:13
@hengm3467 hengm3467 mentioned this pull request Jan 28, 2023
Closed
@bernscode bernscode mentioned this pull request Feb 2, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuyufjh fuyufjh Awaiting requested review from fuyufjh

@xiangjinwu xiangjinwu Awaiting requested review from xiangjinwu

2 more reviewers

@wangrunji0408 wangrunji0408 wangrunji0408 left review comments

@BowenXiao1999 BowenXiao1999 BowenXiao1999 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature. user-facing-changes Contains changes that are visible to users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TennyZhuang @lmatz @wangrunji0408 @BowenXiao1999