Skip to content

Conversation

@KivenChen
Copy link
Contributor

@KivenChen KivenChen commented Nov 28, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR integrates e2e tests for sink in PR & main branch workflows, which covers:

  • mysql sink (already there, not integrated)
  • connector sink via jdbc to postgres (newly added)
  • create-as-sink queries
  • any future e2e tests that matches (e2e/sink/*.slt)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Release note

Refer to a related PR or issue link (optional)

@KivenChen KivenChen requested a review from wenym1 November 28, 2022 10:08
@github-actions github-actions bot added the type/feature Type: New feature. label Nov 28, 2022
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM

@KivenChen KivenChen force-pushed the kiv/remote-sink-e2e branch from 06dba53 to 26ab407 Compare December 1, 2022 08:35
@KivenChen KivenChen force-pushed the kiv/remote-sink-e2e branch from 26ab407 to a56407f Compare December 1, 2022 08:39
@KivenChen
Copy link
Contributor Author

Ready for a final review after all fixes cc @wenym1

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #6631 (448923d) into main (2ca4a98) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #6631      +/-   ##
==========================================
- Coverage   73.21%   73.20%   -0.02%     
==========================================
  Files        1023     1023              
  Lines      163447   163458      +11     
==========================================
- Hits       119674   119663      -11     
- Misses      43773    43795      +22     
Flag Coverage Δ
rust 73.20% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connector/src/sink/remote.rs 63.07% <0.00%> (-1.84%) ⬇️
src/batch/src/executor/group_top_n.rs 68.42% <0.00%> (-6.44%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KivenChen
Copy link
Contributor Author

KivenChen commented Dec 2, 2022

Added a fix for #6648 which wasn't exposed by ci, because before this PR all sink e2e tests were just put there and not integrated into ci at all...

@KivenChen KivenChen changed the title feat(ci): add e2e tests for connector sink feat(ci): add e2e tests for connector sink and integrate sink e2e tests to ci Dec 2, 2022
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 9d28ab4 into main Dec 6, 2022
@mergify mergify bot deleted the kiv/remote-sink-e2e branch December 6, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants