-
Notifications
You must be signed in to change notification settings - Fork 707
feat(ci): add e2e tests for connector sink and integrate sink e2e tests to ci #6631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4049e3d to
bef9dc9
Compare
tabVersion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally LGTM
06dba53 to
26ab407
Compare
26ab407 to
a56407f
Compare
…data/risingwave into kiv/remote-sink-e2e
|
Ready for a final review after all fixes cc @wenym1 |
Codecov Report
@@ Coverage Diff @@
## main #6631 +/- ##
==========================================
- Coverage 73.21% 73.20% -0.02%
==========================================
Files 1023 1023
Lines 163447 163458 +11
==========================================
- Hits 119674 119663 -11
- Misses 43773 43795 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…into kiv/remote-sink-e2e
…data/risingwave into kiv/remote-sink-e2e
|
Added a fix for #6648 which wasn't exposed by ci, because before this PR all sink e2e tests were just put there and not integrated into ci at all... |
wenym1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR integrates e2e tests for sink in PR & main branch workflows, which covers:
e2e/sink/*.slt)Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
Refer to a related PR or issue link (optional)