feat: Introducing JoinConditionTypeCoerceRule #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmatz
approved these changes
Mar 3, 2022
fuyufjh
reviewed
Mar 3, 2022
| if (c.getOperands().stream().allMatch(x -> x instanceof RexInputRef)) { | ||
| var ref1 = (RexInputRef) c.getOperands().get(0); | ||
| var ref2 = (RexInputRef) c.getOperands().get(1); | ||
| return !SqlTypeUtil.equalSansNullability( |
Collaborator
There was a problem hiding this comment.
Does INT64 equal INT32 in this check?
Collaborator
There was a problem hiding this comment.
Hmmm... I just read some code and it seems not.
I am okay with both, just to make sure we know the behavior.
fuyufjh
approved these changes
Mar 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #663 +/- ##
============================================
- Coverage 71.35% 71.27% -0.09%
- Complexity 2699 2706 +7
============================================
Files 891 895 +4
Lines 50659 51228 +569
Branches 1723 1730 +7
============================================
+ Hits 36148 36511 +363
- Misses 13699 13902 +203
- Partials 812 815 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
RT
Checklist
Refer to a related PR or issue link (optional)
See #521