Skip to content

feat: Introducing SimplifyFilterConditionRuleTest #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2022
Merged

feat: Introducing SimplifyFilterConditionRuleTest #637

merged 2 commits into from
Mar 2, 2022

Conversation

@liurenjie1024
Copy link
Contributor

@liurenjie1024 liurenjie1024 commented Mar 2, 2022

What's changed and what's your intention?

RT

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

See #521

@liurenjie1024 liurenjie1024 requested review from fuyufjh and lmatz March 2, 2022 07:44
@github-actions github-actions bot added the type/feature Type: New feature. label Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #637 (7b394de) into main (7796ce4) will increase coverage by 0.16%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #637      +/-   ##
============================================
+ Coverage     71.37%   71.53%   +0.16%     
- Complexity     2683     2699      +16     
============================================
  Files           882      887       +5     
  Lines         50080    50670     +590     
  Branches       1723     1723              
============================================
+ Hits          35743    36249     +506     
- Misses        13533    13609      +76     
- Partials        804      812       +8
Flag Coverage Δ
java 60.06% <88.23%> (+0.77%) ⬆️
rust 76.53% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/com/risingwave/common/config/Configuration.java 56.14% <ø> (ø)
...ngwave/execution/context/SessionConfiguration.java 87.50% <ø> (+37.50%) ⬆️
...risingwave/planner/planner/batch/BatchPlanner.java 92.98% <71.42%> (-1.47%) ⬇️
...a/com/risingwave/planner/planner/PlannerUtils.java 43.19% <84.61%> (+42.01%) ⬆️
...wave/common/config/BatchPlannerConfigurations.java 100.00% <100.00%> (ø)
...isingwave/planner/program/HepOptimizerProgram.java 71.42% <100.00%> (+2.19%) ⬆️
.../logical/subquery/SimplifyFilterConditionRule.java 100.00% <100.00%> (+100.00%) ⬆️
.../java/com/risingwave/planner/sql/SqlConverter.java 91.83% <100.00%> (+4.33%) ⬆️
rust/frontend/src/handler/explain.rs 0.00% <0.00%> (-98.42%) ⬇️
rust/rpc_client/src/meta_client.rs 47.97% <0.00%> (-42.51%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7796ce4...7b394de. Read the comment docs.

lmatz
lmatz approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I may free ride on this PR for the tpch q19.

@liurenjie1024 liurenjie1024 merged commit b3667a7 into main Mar 2, 2022
@liurenjie1024 liurenjie1024 deleted the feat/per_rule_test branch March 2, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmatz lmatz lmatz approved these changes

@fuyufjh fuyufjh fuyufjh approved these changes

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liurenjie1024 @lmatz @fuyufjh