fix(connector): make kinesis work again #6317
Merged
+37
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabVersion <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #6317 +/- ##
==========================================
- Coverage 74.41% 74.41% -0.01%
==========================================
Files 952 953 +1
Lines 154999 155119 +120
==========================================
+ Hits 115345 115427 +82
- Misses 39654 39692 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
LGTM. But the title is somewhat mismatched with the content. I feel it's more of a "feat" rather than a "fix". And without this PR I think kinesis can still "work". "feat(connector): support options to specify offsets for kinesis" would be more appropriate. |
Contributor
Author
I insist the pr be a fix. we would get into an |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
as title, add kinesis properties, allowing start consuming from the given position, earliest and latest.
Checklist
./risedev check(or alias,./risedev c)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
add two fields in WITH options
scan.startup.mode: specify the position for start consuming. accept values:latest,earliest,sequence_number, defaultearliestscan.startup.sequence_number: specify a offset to start consuming. This field is only available and required when settingscan.startup.modetosequence_numberRefer to a related PR or issue link (optional)