Skip to content

Conversation

@liurenjie1024
Copy link
Contributor

What's changed and what's your intention?

Introduce join push expression rule

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

See #521

@liurenjie1024 liurenjie1024 requested review from fuyufjh and lmatz March 1, 2022 03:04
@github-actions github-actions bot added the type/feature Type: New feature. label Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #603 (1abfbce) into main (5719e31) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #603      +/-   ##
============================================
- Coverage     71.83%   71.81%   -0.03%     
  Complexity     2682     2682              
============================================
  Files           883      884       +1     
  Lines         49754    49767      +13     
  Branches       1692     1694       +2     
============================================
- Hits          35739    35738       -1     
- Misses        13211    13225      +14     
  Partials        804      804              
Flag Coverage Δ
java 59.86% <0.00%> (-0.06%) ⬇️
rust 77.06% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ules/logical/subquery/JoinPushExpressionsRule.java 0.00% <0.00%> (ø)
...r/rules/logical/subquery/SubQueryDecorrelator.java 0.00% <ø> (ø)
rust/meta/src/hummock/compaction.rs 68.21% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5719e31...1abfbce. Read the comment docs.

@liurenjie1024 liurenjie1024 enabled auto-merge (squash) March 1, 2022 03:20
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liurenjie1024 liurenjie1024 merged commit 09fd260 into main Mar 1, 2022
@liurenjie1024 liurenjie1024 deleted the feat/introduce_join_push_expression_rule branch March 1, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants